fix: correct pre-existing test failures in MediaStoreGatewayFactoryTest and ServerSetupScreenTest

- MediaStoreGatewayFactoryTest: Replace unreliable Java reflection SDK mocking with MockK static function mocking for shouldUseNewMediaStore()
- ServerSetupScreenTest: Fix button text assertions (Setup -> Start) and state management for custom model toggle

Author: crim50n

data/src/test/java/dev/minios/pdaiv1/data/gateway/mediastore/MediaStoreGatewayFactoryTest.kt

@@ -1,14 +1,16 @@
 package dev.minios.pdaiv1.data.gateway.mediastore
 
 import android.content.Context
-import android.os.Build
+import dev.minios.pdaiv1.core.common.extensions.shouldUseNewMediaStore
 import dev.minios.pdaiv1.core.common.file.FileProviderDescriptor
+import io.mockk.every
 import io.mockk.mockk
+import io.mockk.mockkStatic
+import io.mockk.unmockkStatic
+import org.junit.After
 import org.junit.Assert
+import org.junit.Before
 import org.junit.Test
-import java.lang.reflect.Field
-import java.lang.reflect.Method
-import java.lang.reflect.Modifier
 
 class MediaStoreGatewayFactoryTest {
 
@@ -20,62 +22,41 @@ class MediaStoreGatewayFactoryTest {
         fileProviderDescriptor = stubFileProviderDescriptor,
     )
 
+    @Before
+    fun setUp() {
+        mockkStatic(::shouldUseNewMediaStore)
+    }
+
+    @After
+    fun tearDown() {
+        unmockkStatic(::shouldUseNewMediaStore)
+    }
+
     @Test
     fun `given app running on Android SDK 26 (O), expected factory returned instance of type MediaStoreGatewayOldImpl`() {
-        mockSdkInt(Build.VERSION_CODES.O)
+        every { shouldUseNewMediaStore() } returns false
         val actual = factory.invoke()
         Assert.assertEquals(true, actual is MediaStoreGatewayOldImpl)
     }
 
     @Test
     fun `given app running on Android SDK 31 (S), expected factory returned instance of type MediaStoreGatewayOldImpl`() {
-        mockSdkInt(Build.VERSION_CODES.S)
+        every { shouldUseNewMediaStore() } returns false
         val actual = factory.invoke()
         Assert.assertEquals(true, actual is MediaStoreGatewayOldImpl)
     }
 
     @Test
-    fun `given app running on Android SDK 32 (S_V2), expected factory returned instance of type MediaStoreGatewayOldImpl`() {
-        mockSdkInt(Build.VERSION_CODES.S_V2)
+    fun `given app running on Android SDK 32 (S_V2), expected factory returned instance of type MediaStoreGatewayImpl`() {
+        every { shouldUseNewMediaStore() } returns true
         val actual = factory.invoke()
         Assert.assertEquals(true, actual is MediaStoreGatewayImpl)
     }
 
     @Test
-    fun `given app running on Android SDK 34 (UPSIDE_DOWN_CAKE), expected factory returned instance of type MediaStoreGatewayOldImpl`() {
-        mockSdkInt(Build.VERSION_CODES.UPSIDE_DOWN_CAKE)
+    fun `given app running on Android SDK 34 (UPSIDE_DOWN_CAKE), expected factory returned instance of type MediaStoreGatewayImpl`() {
+        every { shouldUseNewMediaStore() } returns true
         val actual = factory.invoke()
         Assert.assertEquals(true, actual is MediaStoreGatewayImpl)
     }
-
-    private fun mockSdkInt(sdkInt: Int) {
-        val sdkIntField = Build.VERSION::class.java.getField("SDK_INT")
-        sdkIntField.isAccessible = true
-        getModifiersField().also {
-            it.isAccessible = true
-            it.set(sdkIntField, sdkIntField.modifiers and Modifier.FINAL.inv())
-        }
-        sdkIntField.set(null, sdkInt)
-    }
-
-    private fun getModifiersField(): Field {
-        return try {
-            Field::class.java.getDeclaredField("modifiers")
-        } catch (e: NoSuchFieldException) {
-            try {
-                val getDeclaredFields0: Method =
-                    Class::class.java.getDeclaredMethod("getDeclaredFields0", Boolean::class.javaPrimitiveType)
-                getDeclaredFields0.isAccessible = true
-                val fields = getDeclaredFields0.invoke(Field::class.java, false) as Array<Field>
-                for (field in fields) {
-                    if ("modifiers" == field.name) {
-                        return field
-                    }
-                }
-            } catch (ex: ReflectiveOperationException) {
-                e.addSuppressed(ex)
-            }
-            throw e
-        }
-    }
 }

presentation/src/test/java/dev/minios/pdaiv1/presentation/screen/setup/ServerSetupScreenTest.kt

@@ -114,11 +114,11 @@ class ServerSetupScreenTest : CoreComposeTest {
         setupButton
             .assertIsDisplayed()
             .assertIsNotEnabled()
-            .assertTextEquals("Setup")
+            .assertTextEquals("Start")
     }
 
     @Test
-    fun `given user is on CONFIGURE tab with LOCAL server source, clicks Switch, expected main button with Setup text becomes enabled then clicks Switch again, expected main button with Setup text becomes disabled`() {
+    fun `given user is on CONFIGURE tab with LOCAL server source, clicks Switch, expected main button with Start text becomes enabled then clicks Switch again, expected main button with Start text becomes disabled`() {
         composeTestRule.setContent {
             ServerSetupScreen(viewModel = stubViewModel)
         }
@@ -134,7 +134,7 @@ class ServerSetupScreenTest : CoreComposeTest {
         setupButton
             .assertIsDisplayed()
             .assertIsNotEnabled()
-            .assertTextEquals("Setup")
+            .assertTextEquals("Start")
         switch
             .assertIsDisplayed()
             .assertIsOff()
@@ -144,19 +144,22 @@ class ServerSetupScreenTest : CoreComposeTest {
         stubUiState.update {
             it.copy(
                 localOnnxCustomModel = true,
-                localOnnxModels = it.localOnnxModels.withNewState(
-                    it.localOnnxModels.find { m -> m.id == LocalAiModel.CustomOnnx.id }!!.copy(
+                scannedOnnxCustomModels = listOf(
+                    ServerSetupState.LocalModel(
+                        id = "custom_model",
+                        name = "Custom Model",
+                        size = "1GB",
+                        downloaded = true,
                         selected = true,
-                        downloaded = true
-                    ),
+                    )
                 ),
             )
         }
 
         setupButton
             .assertIsDisplayed()
             .assertIsEnabled()
-            .assertTextEquals("Setup")
+            .assertTextEquals("Start")
         switch
             .assertIsDisplayed()
             .assertIsOn()
@@ -166,18 +169,14 @@ class ServerSetupScreenTest : CoreComposeTest {
         stubUiState.update {
             it.copy(
                 localOnnxCustomModel = false,
-                localOnnxModels = it.localOnnxModels.withNewState(
-                    it.localOnnxModels.find { m -> m.id == LocalAiModel.CustomOnnx.id }!!.copy(
-                        selected = false,
-                    ),
-                ),
+                scannedOnnxCustomModels = emptyList(),
             )
         }
 
         setupButton
             .assertIsDisplayed()
             .assertIsNotEnabled()
-            .assertTextEquals("Setup")
+            .assertTextEquals("Start")
         switch
             .assertIsDisplayed()
             .assertIsOff()