Run the schema extender only if necessary (#1076)

* Run the schema extender only if necessary

* call `run.ossdataflow` in scanner CPG creation

Author: fabsx00

console/src/main/scala/io/shiftleft/console/BridgeBase.scala

@@ -146,7 +146,7 @@ trait BridgeBase {
           if (config.server) {
             startHttpServer(config)
           } else if (config.pluginToRun.isDefined) {
-            runBundle(config)
+            runPlugin(config)
           } else {
             startInteractiveShell(config, slProduct)
           }
@@ -180,7 +180,7 @@ trait BridgeBase {
     }
   }
 
-  private def runBundle(config: Config): Unit = {
+  private def runPlugin(config: Config): Unit = {
     if (config.src.isEmpty) {
       println("You must supply a source directory with the --src flag")
       return
@@ -196,6 +196,7 @@ trait BridgeBase {
         |   .filter(_.inputPath == "$src")
         |   .map(_.name).foreach(n => workspace.removeProject(n))
         |   importCode.$language("$src")
+        |   run.ossdataflow
         |   save
         | } else {
         |    println("Using existing CPG - Use `--overwrite` if this is not what you want")

console/src/main/scala/io/shiftleft/console/PluginManager.scala

@@ -60,21 +60,26 @@ class PluginManager(val installDir: File) {
   }
 
   private def installSchemaExtensions(file: File, pluginName: String): Unit = {
-    schemaDir.foreach { sDir =>
-      file.listRecursively
+    val copyOps = schemaDir.toList.flatMap { sDir =>
+      file.listRecursively.toList
         .filter(_.path.toString.contains("schema"))
         .filter(_.name.endsWith(".json"))
-        .foreach { json =>
+        .map { json =>
           val name = json.name
           val dstFileName = s"joernext-$pluginName-$name"
           cp(json, sDir / dstFileName)
+          json
         }
     }
-    try {
-      Process("./schema-extender.sh", installDir.toJava).!!
-    } catch {
-      case e: Exception =>
-        System.err.println(s"Error running schema-extender: ${e.getMessage}")
+
+    if (copyOps.nonEmpty) {
+      println("Plugin modifies the schema. Running schema extender.")
+      try {
+        Process("./schema-extender.sh", installDir.toJava).!!
+      } catch {
+        case e: Exception =>
+          System.err.println(s"Error running schema-extender: ${e.getMessage}")
+      }
     }
   }