Add a new MODULE modifier. (#1745)

* Add a new MODULE modifier.

This new MODULE modifier is to be used for methods which define a module
in sense of Python or Javascript where a module method creates a module
object.

* Rebase and generate domain classes again.

Author: ml86

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/ModifierTypes.java

@@ -41,6 +41,9 @@ public class ModifierTypes {
 /** The readonly modifier */
 public static final String READONLY = "READONLY";
 
+/** Indicate that a method defines a module in the sense e.g. a python module does with the creation of a module object */
+public static final String MODULE = "MODULE";
+
 
 public static Set<String> ALL = new HashSet<String>() {{
 add(STATIC);
@@ -54,6 +57,7 @@ public class ModifierTypes {
 add(INTERNAL);
 add(FINAL);
 add(READONLY);
+add(MODULE);
 }};
 
 }

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/nodes/ClosureBinding.scala

@@ -79,11 +79,11 @@ class ClosureBinding(graph_4762: Graph, id_4762: Long /*cf https://github.com/sc
 
   /** Traverse to LOCAL via REF OUT edge.
     */
-  def _localViaRefOut: Local = get()._localViaRefOut
+  def _localViaRefOut: Option[Local] = get()._localViaRefOut
 
   /** Traverse to METHOD_PARAMETER_IN via REF OUT edge.
     */
-  def _methodParameterInViaRefOut: overflowdb.traversal.Traversal[MethodParameterIn] = get()._methodParameterInViaRefOut
+  def _methodParameterInViaRefOut: Option[MethodParameterIn] = get()._methodParameterInViaRefOut
 
   def captureIn: Iterator[Expression] = get().captureIn
   override def _captureIn             = get()._captureIn
@@ -176,18 +176,10 @@ class ClosureBindingDb(ref: NodeRef[NodeDb]) extends NodeDb(ref) with StoredNode
   }
 
   import overflowdb.traversal._
-  def refOut: Iterator[AstNode] = createAdjacentNodeScalaIteratorByOffSet[AstNode](0)
-  override def _refOut          = createAdjacentNodeScalaIteratorByOffSet[StoredNode](0)
-  def _localViaRefOut: Local = try { refOut.collectAll[Local].next() }
-  catch {
-    case e: java.util.NoSuchElementException =>
-      throw new overflowdb.SchemaViolationException(
-        "OUT edge with label REF to an adjacent LOCAL is mandatory, but not defined for this CLOSURE_BINDING node with id=" + id,
-        e
-      )
-  }
-  def _methodParameterInViaRefOut: overflowdb.traversal.Traversal[MethodParameterIn] =
-    refOut.collectAll[MethodParameterIn]
+  def refOut: Iterator[AstNode]                              = createAdjacentNodeScalaIteratorByOffSet[AstNode](0)
+  override def _refOut                                       = createAdjacentNodeScalaIteratorByOffSet[StoredNode](0)
+  def _localViaRefOut: Option[Local]                         = refOut.collectAll[Local].nextOption()
+  def _methodParameterInViaRefOut: Option[MethodParameterIn] = refOut.collectAll[MethodParameterIn].nextOption()
 
   def captureIn: Iterator[Expression] = createAdjacentNodeScalaIteratorByOffSet[Expression](1)
   override def _captureIn             = createAdjacentNodeScalaIteratorByOffSet[StoredNode](1)

schema/src/main/scala/io/shiftleft/codepropertygraph/schema/Ast.scala

@@ -231,7 +231,15 @@ object Ast extends SchemaBase {
       Constant(name = "FINAL", value = "FINAL", valueType = ValueType.String, comment = "The final modifier")
         .protoId(10),
       Constant(name = "READONLY", value = "READONLY", valueType = ValueType.String, comment = "The readonly modifier")
-        .protoId(11)
+        .protoId(11),
+      Constant(
+        name = "MODULE",
+        value = "MODULE",
+        valueType = ValueType.String,
+        comment =
+          "Indicate that a method defines a module in the sense e.g. a python module does with the creation of a module object"
+      )
+        .protoId(12)
     )
 
     val modifier: NodeType = builder