Commit cbf3d67
committed
fixes:
- typo fix in comment
- At least on some Win10 machines, attempting to execute a *non-existent* `"%NASMPATH%\nasm.exe"` will cause the subsequent `%ERRORLEVEL% equ 0` check to **pass** inadvertently, hence we MUST first check whether the indicated nasm.exe exists, truly, before running this version test/check in the installer batch script.
- At least on Win10, when NASM had already been previously installed using the standard Windows NASM installer application, the path to the nasm.exe WILL contain spaces (`C:/Program Files...`) and we must make sure our installer batch script correctly deals with this scenario, requiring paths to be surrounded by `"` double quotes.
- Expanded the error/progress messages in the installer batch script a bit to make them more useful and legible when the `NASMPATH` environment variable has not been set up or is (probably erroneously) *empty*: now at least one of the installer progress messages allows the user to diagnose this scenario.1 parent 718132a commit cbf3d67
2 files changed
Lines changed: 11 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
| 312 | + | |
313 | 313 | | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
320 | 322 | | |
321 | 323 | | |
322 | 324 | | |
323 | | - | |
| 325 | + | |
324 | 326 | | |
325 | 327 | | |
326 | 328 | | |
| |||
0 commit comments