Conversation
Agent-Logs-Url: https://github.com/ShigureLab/docufix/sessions/bba5e264-e283-46f3-bfb6-70912f2ac133 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
| "recommendations": [ | ||
| "ms-python.python", | ||
| "astral-sh.ty", | ||
| "ms-python.vscode-pylance", |
Agent-Logs-Url: https://github.com/ShigureLab/docufix/sessions/6002ca7f-3bec-4d61-93fc-31e056cf9def Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the project’s type-checking workflow from Pyright to Astral’s ty, updates dev dependencies/lockfile accordingly, and adjusts related lint/editor settings.
Changes:
- Replace
pyrightwithtyin dev dependencies, lockfile, andjust linttask. - Remove the old Pyright configuration and re-enable Ruff’s unused import/variable checks.
- Adjust a
Colortype alias soty check --error-on-warningpasses.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Removes pyright (+ nodeenv) and adds ty to the resolved dev dependency set. |
src/docufix/utils/colorful.py |
Fixes Color type alias to be compatible with ty’s checks. |
pyproject.toml |
Swaps dev dependency from Pyright to ty, removes [tool.pyright], and re-enables Ruff F401/F841. |
justfile |
Updates lint task to run ty check --error-on-warning instead of Pyright. |
.vscode/settings.json |
Removes the Pyright-style strict type-check mode setting. |
.vscode/extensions.json |
Recommends the ty VS Code extension instead of Pylance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ms-python.python", | ||
| "ms-python.vscode-pylance", | ||
| "astral-sh.ty", | ||
| "charliermarsh.ruff", | ||
| "esbenp.prettier-vscode", |
There was a problem hiding this comment.
.vscode/settings.json still contains Pylance-specific analysis/inlay-hint settings, and the PR description mentions keeping VS Code recommendations aligned with those settings, but this change removes the ms-python.vscode-pylance extension recommendation. Consider re-adding Pylance to the recommendations list (alongside astral-sh.ty), or remove the Pylance-specific settings if Pylance is no longer intended to be used.
Summary
--error-on-warningValidation
python -m uv run ty check --error-on-warning src/docufix testspython -m uv run ruff check .python -m uv run pytest --reruns 3 --reruns-delay 1python -m uv buildnpx prettier --check '**/*.md'References