Skip to content

Add UKF#26

Merged
ShisatoYano merged 2 commits into
ShisatoYano:mainfrom
Kaloum2:feature/develop_ukf
Dec 29, 2025
Merged

Add UKF#26
ShisatoYano merged 2 commits into
ShisatoYano:mainfrom
Kaloum2:feature/develop_ukf

Conversation

@Kaloum2

@Kaloum2 Kaloum2 commented Dec 28, 2025

Copy link
Copy Markdown

Add Unscented Kalman Filter (UKF) for Localization following the same patterns as the existing EKF implementation
This PR implements UKF for vehicle localization with:

  • New UnscentedKalmanFilterLocalizer component
  • Standalone UKF simulation
  • Comparative EKF vs UKF simulation

@ShisatoYano

Copy link
Copy Markdown
Owner

Hi @Kaloum2. Thank you for sending me this PR and it is LGTM!!

@ShisatoYano

Copy link
Copy Markdown
Owner

Additionally, please add the following items.

  • Animation gif files of UKF and EKF vs UKF. You can create those gif files by specifying the name of file as input argument when global_xy_visualizer is initialized here
  • Unit test codes of them. You can refer to the existing test code of EKF

@ShisatoYano ShisatoYano self-requested a review December 29, 2025 09:57
@ShisatoYano ShisatoYano added the enhancement New feature or request label Dec 29, 2025
@Kaloum2

Kaloum2 commented Dec 29, 2025

Copy link
Copy Markdown
Author

Hi @ShisatoYano, I added the test and animation files for UKF and UKF vs EKF

@ShisatoYano ShisatoYano merged commit 3113020 into ShisatoYano:main Dec 29, 2025
3 checks passed
@ShisatoYano

Copy link
Copy Markdown
Owner

Thanks @Kaloum2! I merged it!!

@ShisatoYano ShisatoYano left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShisatoYano

Copy link
Copy Markdown
Owner

Hi @Kaloum2, if you have, could you tell me your LinkedIn account and X account? I will share your PR on them and mention your account.

@Kaloum2

Kaloum2 commented Dec 31, 2025

Copy link
Copy Markdown
Author

Hi @ShisatoYano, thanks
My LinkedIn account is
https://www.linkedin.com/in/bruno-dokpomiwa
and my x account is https://x.com/BrunoIkr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants