Skip to content

Commit 3782251

Browse files
Widen workspace filters for react-native CI runs (#154)
### What changes are you making? Not running react-native when swift/android changes are detected results in false positive CI runs and broken CI on main ![image.png](https://app.graphite.com/user-attachments/assets/c6a9231a-dbef-4204-a2cd-78cf8f582650.png) ### How to test <!-- Please outline the steps to test your changes --> --- ### Before you merge > [!IMPORTANT] > > - [ ] I've added tests to support my implementation > - [ ] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md) > - [ ] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md) > - [ ] I've updated the relevant platform README (`platforms/swift/README.md` and/or `platforms/android/README.md`) --- <details> <summary>Releasing a new Swift version?</summary> - [ ] I have bumped the version in `ShopifyCheckoutKit.podspec` - [ ] I have bumped the version in `platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift` - [ ] I have updated `platforms/swift/CHANGELOG.md` - [ ] I have updated the SwiftPM/CocoaPods version snippets in `platforms/swift/README.md` (major version only) </details> <details> <summary>Releasing a new Android version?</summary> - [ ] I have bumped the `versionName` in `platforms/android/lib/build.gradle` - [ ] I have updated `platforms/android/CHANGELOG.md` - [ ] I have updated the Gradle/Maven version snippets in `platforms/android/README.md` </details> > [!TIP] > See the [Contributing documentation](./CONTRIBUTING.md) for the full release process per platform.
1 parent e1cf4b5 commit 3782251

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,13 @@ jobs:
3737
filters: |
3838
android:
3939
- 'platforms/android/**'
40+
- 'protocol/**'
4041
- '.github/workflows/android-test.yml'
4142
- '.github/workflows/android-license-headers.yml'
4243
- '.github/workflows/ci.yml'
4344
swift:
4445
- 'platforms/swift/**'
46+
- 'protocol/**'
4547
- 'Package.swift'
4648
- 'Package.resolved'
4749
- '.github/workflows/swift-test-package.yml'
@@ -51,6 +53,11 @@ jobs:
5153
- '.github/workflows/ci.yml'
5254
reactNative:
5355
- 'platforms/react-native/**'
56+
- 'platforms/swift/**'
57+
- 'platforms/android/**'
58+
- 'protocol/**'
59+
- 'Package.swift'
60+
- 'Package.resolved'
5461
- '.github/workflows/rn-test.yml'
5562
- '.github/workflows/rn-test-android.yml'
5663
- '.github/workflows/rn-test-ios.yml'

0 commit comments

Comments
 (0)