Build React Native Android E2E APK artifact

Assisted-By: devx/396ca0c4-44ad-415d-8d80-7200df4e42a4

Author: kieran-osgood-shopify

e2e/BITRISE.md

@@ -60,6 +60,11 @@ The non-secret E2E defaults are defined in `e2e/bitrise.yml` under `app.envs`. D
 
 Secrets still need to be configured in Bitrise.io.
 
+| Secret | Purpose |
+|---|---|
+| `STOREFRONT_DOMAIN` | Required by `scripts/setup_storefront_env` for sample app builds. |
+| `STOREFRONT_ACCESS_TOKEN` | Required by `scripts/setup_storefront_env` for sample app builds. |
+
 ## Future secrets
 
 Do not add BrowserStack credentials until the BrowserStack integration phase.
@@ -81,6 +86,8 @@ React Native iOS IPA generation is added in a later phase and will require Bitri
 
 ## Caching
 
+React Native Android E2E builds use the released native Maven artifact versions declared by the React Native sample and module configuration. Do not set local native SDK override flags for these builds.
+
 The skeleton includes placeholders for:
 
 - key-based pnpm/CocoaPods/Gradle cache paths

e2e/bitrise.yml

@@ -89,13 +89,20 @@ workflows:
                 rn-android-{{ checksum "platforms/react-native/pnpm-lock.yaml" }}-{{ checksum "platforms/react-native/sample/android/**/*.gradle*" }}
       - activate-build-cache-for-gradle: {}
       - script@1:
-          title: Create React Native Android artifact placeholder
+          title: Build React Native Android APK artifact
           inputs:
             - content: |-
                 set -euo pipefail
-                mkdir -p "$BITRISE_DEPLOY_DIR/e2e"
-                echo "Phase 2 placeholder for React Native Android APK" > "$BITRISE_DEPLOY_DIR/e2e/react-native-android.apk"
-                envman add --key E2E_REACT_NATIVE_ANDROID_APP_PATH --value "$BITRISE_DEPLOY_DIR/e2e/react-native-android.apk"
+                corepack enable
+                pnpm install --frozen-lockfile
+                ./scripts/setup_storefront_env --skip-optional-prompts
+                cd platforms/react-native
+                pnpm module build
+                cd sample/android
+                ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a
+                android_apk="$PWD/app/build/outputs/apk/debug/app-debug.apk"
+                test -f "$android_apk"
+                envman add --key E2E_REACT_NATIVE_ANDROID_APP_PATH --value "$android_apk"
       - deploy-to-bitrise-io@2:
           inputs:
             - pipeline_intermediate_files: |-

e2e/test/bitrise_pipeline_test.rb

@@ -73,6 +73,26 @@ def test_dev_up_installs_bitrise_cli
     assert_includes packages, "bitrise"
   end
 
+  def test_react_native_android_workflow_builds_real_apk_artifact
+    script = workflow_script("e2e-build-react-native-android")
+
+    assert_includes script, "corepack enable"
+    assert_includes script, "pnpm install --frozen-lockfile"
+    assert_includes script, "./scripts/setup_storefront_env --skip-optional-prompts"
+    assert_includes script, "pnpm module build"
+    assert_includes script, "./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a"
+    assert_includes script, "app/build/outputs/apk/debug/app-debug.apk"
+    refute_includes script, "Phase 2 placeholder for React Native Android APK"
+  end
+
+  def test_react_native_android_workflow_does_not_use_local_native_sdk_overrides
+    script = workflow_script("e2e-build-react-native-android")
+
+    refute_includes script, "USE_LOCAL_SDK"
+    refute_includes script, "publish_android_snapshot"
+    refute_includes script, "--local"
+  end
+
   def test_bitrise_setup_docs_exist
     assert File.exist?("e2e/BITRISE.md")
   end
@@ -83,6 +103,16 @@ def load_bitrise_config
     YAML.safe_load_file(BITRISE_CONFIG_PATH)
   end
 
+  def workflow_script(workflow)
+    steps = load_bitrise_config.fetch("workflows").fetch(workflow).fetch("steps")
+    steps.filter_map do |step|
+      step_value = step.values.first
+      next unless step.keys.first.start_with?("script")
+
+      step_value.fetch("inputs", []).find { |input| input.key?("content") }&.fetch("content")
+    end.join("\n")
+  end
+
   def expected_workflows
     [
       "e2e-package-suite",