ensure loading bar disappears on page finished (#188)

Author: kiftio

platforms/android/lib/src/main/java/com/shopify/checkoutkit/EmbeddedCheckoutProtocol.kt

@@ -111,9 +111,9 @@ internal class EmbeddedCheckoutProtocol(
         )
 
     private fun handleStart(message: String) {
-        log.d(LOG_TAG, "Handling $METHOD_START: showing progress bar and bubbling up.")
+        log.d(LOG_TAG, "Handling $METHOD_START: hiding progress bar and bubbling up.")
         onMainThread {
-            view.getListener().onCheckoutViewLoadStarted()
+            view.getListener().onCheckoutViewLoadComplete()
             client?.process(message)
         }
     }

platforms/android/lib/src/test/java/com/shopify/checkoutkit/EmbeddedCheckoutProtocolTest.kt

@@ -338,10 +338,10 @@ class EmbeddedCheckoutProtocolTest {
     // region ec.start
 
     @Test
-    fun `ec start shows progress bar`() {
+    fun `ec start hides progress bar`() {
         ecp.postMessage("""{"jsonrpc":"2.0","method":"ec.start","params":{"checkout":{}}}""")
         shadowOf(Looper.getMainLooper()).runToEndOfTasks()
-        verify(mockListener).onCheckoutViewLoadStarted()
+        verify(mockListener).onCheckoutViewLoadComplete()
     }
 
     @Test