Migrate React Native sample to Expo prebuild#297
Draft
kieran-osgood-shopify wants to merge 7 commits into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kieran-osgood-shopify
force-pushed
the
cx-expo-prebuild-migration
branch
4 times, most recently
from
fed581f to
525dc82
Compare
kieran-osgood-shopify
force-pushed
the
cx-expo-prebuild-migration
branch
3 times, most recently
from
4e0e1bc to
e8d8056
Compare
| working-directory: platforms/react-native/sample | ||
|
|
||
| - name: Verify iOS lockfile uses published native SDK | ||
| run: scripts/check_published_podfile_lock sample/ios/Podfile.lock |
Contributor
Author
There was a problem hiding this comment.
This is now inlined into the platforms/react-native/sample/scripts/build_ios script
Assisted-By: devx/fb34cb30-8090-438b-b735-1d8f8eb128a6
Assisted-By: devx/741457bb-fda8-43d5-b35b-2e08c409a2fe
Assisted-By: devx/2d0344dc-43dd-4535-baf2-409ff9e93de5
Assisted-By: devx/c25009c8-5a1d-4cb8-aee9-2dcf64902080
Assisted-By: devx/058cd5b9-f1cc-431b-b520-15657ace50f1
kieran-osgood-shopify
force-pushed
the
cx-expo-prebuild-migration
branch
from
1293856 to
ecf8970
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/297
to
kieran-osgood/cx-expo-prebuild/rct-integration-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This PR is stacked on top of #322, which moves the RN iOS bridge tests into a dedicated XcodeGen/CocoaPods integration app before this PR deletes the generated Expo sample native projects.
Summary
Lockfile maintenance doing some work on the git diff here:
dev rn prebuildcommand with--localsupportexpo install --checkwhere the Shopify package proxy has the recommended version availableValidation
dev rn test iosdev rn test androiddev rn test jsdev rn lintgit diff --checkPrevious validation from this branch before restacking:
dev rn prebuild android --localdev rn prebuild ios --localpnpm exec expo install --checkfromplatforms/react-native/samplepnpm dlx expo-doctorfromplatforms/react-native/samplewas attempted; remaining failures are fromexpo-doctorshelling out tonpm explain, which is blocked by the workspace npm wrapper/minimum dependency age enforcement undershadowenvNotes
platforms/react-native/sample/iosandplatforms/react-native/sample/androidare ignored and regenerated via clean Expo prebuild.expo,expo-build-properties, andexpo-fontare pinned to the newest SDK 56 versions currently available through the Shopify package proxy, and are excluded from Expo dependency validation until the proxy catches up to Expo's latest recommendations.