Skip to content

Add native checkout close selector for RN E2E #333

Merged
kyle-schellen merged 1 commit into
mainfrom
06-23-normalize-rn-checkout-e2e-native-support
Jun 30, 2026
Merged

Add native checkout close selector for RN E2E #333
kyle-schellen merged 1 commit into
mainfrom
06-23-normalize-rn-checkout-e2e-native-support

Conversation

@kyle-schellen

@kyle-schellen kyle-schellen commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What changed

Adds a stable native close-button selector for React Native Maestro E2E tests.

On Swift, the selector is set with accessibilityIdentifier on both close button paths: the default system close button and the custom-tinted close button. This keeps VoiceOver copy on the platform/localized path while giving E2E tests a deterministic hook.

On Android, the checkout toolbar close menu resource id is renamed from checkoutKitCloseBtn to shopify_checkout_kit_close_button so the shared React Native Maestro flow can target the same close selector on both native checkout surfaces.

The React Native iOS accelerated checkout wrapper diff in this PR is formatting-only around the existing SwiftUI environment injection; it does not add or change Apple Pay label/style behavior.

Verification

Added Swift test coverage for the close button identifier on both close button paths.

Updated Android CheckoutDialogTest references to verify the renamed close menu id still drives the existing close/cancel behavior and close icon configuration paths.

Ran:

  • dev swift test
  • dev android test specific CheckoutDialogTest

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

kyle-schellen commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from 8226cc7 to 74bd532 Compare June 25, 2026 18:24
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch from 1570a74 to f2c0391 Compare June 25, 2026 18:24
@kyle-schellen kyle-schellen changed the title Normalize RN checkout E2E native support [WIP] Normalize RN checkout E2E native support Jun 25, 2026
@kyle-schellen kyle-schellen added the #gsd:50662 Rebase Checkout Kit on UCP label Jun 26, 2026 — with Graphite App
@kyle-schellen kyle-schellen self-assigned this Jun 26, 2026
@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from 74bd532 to 2aae967 Compare June 26, 2026 14:56
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch 2 times, most recently from 1a7c432 to ec0567b Compare June 26, 2026 15:36
@kyle-schellen kyle-schellen changed the title [WIP] Normalize RN checkout E2E native support Normalize RN checkout E2E native support Jun 26, 2026
@kyle-schellen kyle-schellen changed the title Normalize RN checkout E2E native support Add native close button hook for RN E2E Jun 26, 2026
@kyle-schellen kyle-schellen changed the title Add native close button hook for RN E2E Add native checkout close selector for RN E2E Jun 26, 2026
@kyle-schellen kyle-schellen marked this pull request as ready for review June 26, 2026 15:56
@kyle-schellen kyle-schellen requested a review from a team as a code owner June 26, 2026 15:56
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.83% (326/355) 87.98% (183/208) 100% (86/86)

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
React Native npm tarball 91.6 KiB 91.6 KiB +13 B
Android release AAR 178.6 KiB 178.6 KiB +22 B

Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report.

@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from 2aae967 to 3c9fe7c Compare June 26, 2026 16:33
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch 4 times, most recently from 6b119f9 to e1620f6 Compare June 29, 2026 02:30
@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from 3c9fe7c to 8bb2060 Compare June 29, 2026 02:30
@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from 8bb2060 to f20281d Compare June 29, 2026 15:44
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch from e1620f6 to 502ae66 Compare June 29, 2026 15:44
@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from f20281d to 760cafc Compare June 29, 2026 16:34
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch from 502ae66 to 12a2da3 Compare June 29, 2026 16:34
@kyle-schellen kyle-schellen force-pushed the 06-23-add-rn-sample-e2e-bootstrap branch from 760cafc to c77059a Compare June 30, 2026 14:07
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch from 12a2da3 to cc25a34 Compare June 30, 2026 14:07

kyle-schellen commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 30, 4:14 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 30, 4:16 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 30, 4:35 PM UTC: @kyle-schellen merged this pull request with Graphite.

@kyle-schellen kyle-schellen changed the base branch from 06-23-add-rn-sample-e2e-bootstrap to graphite-base/333 June 30, 2026 16:14
@kyle-schellen kyle-schellen changed the base branch from graphite-base/333 to main June 30, 2026 16:14
@kyle-schellen kyle-schellen force-pushed the 06-23-normalize-rn-checkout-e2e-native-support branch from cc25a34 to 187c66c Compare June 30, 2026 16:15
@kyle-schellen kyle-schellen merged commit dc2fd82 into main Jun 30, 2026
33 checks passed
@kyle-schellen kyle-schellen deleted the 06-23-normalize-rn-checkout-e2e-native-support branch June 30, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants