Add native checkout close selector for RN E2E #333
Merged
kyle-schellen merged 1 commit intoJun 30, 2026
Conversation
Contributor
Author
This was referenced Jun 25, 2026
8226cc7 to
74bd532
Compare
1570a74 to
f2c0391
Compare
74bd532 to
2aae967
Compare
1a7c432 to
ec0567b
Compare
Package Size
Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report. |
2aae967 to
3c9fe7c
Compare
6b119f9 to
e1620f6
Compare
3c9fe7c to
8bb2060
Compare
kieran-osgood-shopify
approved these changes
Jun 29, 2026
8bb2060 to
f20281d
Compare
e1620f6 to
502ae66
Compare
f20281d to
760cafc
Compare
502ae66 to
12a2da3
Compare
toneymathews
approved these changes
Jun 29, 2026
markmur
approved these changes
Jun 30, 2026
760cafc to
c77059a
Compare
12a2da3 to
cc25a34
Compare
11 tasks
Contributor
Author
Merge activity
|
cc25a34 to
187c66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
Adds a stable native close-button selector for React Native Maestro E2E tests.
On Swift, the selector is set with
accessibilityIdentifieron both close button paths: the default system close button and the custom-tinted close button. This keeps VoiceOver copy on the platform/localized path while giving E2E tests a deterministic hook.On Android, the checkout toolbar close menu resource id is renamed from
checkoutKitCloseBtntoshopify_checkout_kit_close_buttonso the shared React Native Maestro flow can target the same close selector on both native checkout surfaces.The React Native iOS accelerated checkout wrapper diff in this PR is formatting-only around the existing SwiftUI environment injection; it does not add or change Apple Pay label/style behavior.
Verification
Added Swift test coverage for the close button identifier on both close button paths.
Updated Android
CheckoutDialogTestreferences to verify the renamed close menu id still drives the existing close/cancel behavior and close icon configuration paths.Ran:
dev swift testdev android test specific CheckoutDialogTestBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.