feat(web): support checkout color scheme#379
Open
westeezy wants to merge 1 commit into
Open
Conversation
Support `color-scheme` property for `ec_color_scheme`
Web — Coverage Report
|
Package Size
Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report. |
kiftio
reviewed
Jun 30, 2026
| case "auto": | ||
| case null: | ||
| return undefined; | ||
| default: |
Contributor
There was a problem hiding this comment.
do we want to stay full-spec, and just accept light|dark?
https://ucp.dev/latest/specification/embedded-checkout/#color-scheme
omission is no-preference (which is essentially auto)
Contributor
Author
There was a problem hiding this comment.
Oh yes we do good catch!
kiftio
reviewed
Jun 30, 2026
| <label> | ||
| <span>color scheme</span> | ||
| <select name="colorScheme"> | ||
| <option value="auto" selected>auto</option> |
Contributor
There was a problem hiding this comment.
same q as below, maybe we drop this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Support
color-schemeproperty forec_color_schemeHow to test
See sample app
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)