[Draft] Expand protocol to expose full envelope#398
Open
markmur wants to merge 2 commits into
Open
Conversation
Package Size
Web file breakdown
React Native file breakdown
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
The protocol layer now emits the full JSON-RPC envelope (
params: { checkout }/params: { error }) as the UCP spec defines it, instead of pre-narrowing descriptors down to bare payloads. Each host kit re-narrows back to its ergonomic bare-payload API, so public consumer APIs are unchanged — the narrowing just moves from the protocol into the kits.Scope:
ec.*methods only. RN native bridges/JS, sample apps, andModels.*are untouched.Protocol descriptors now carry the envelope
Kotlin (
EmbeddedCheckoutProtocol.kt, generated):Swift (
EmbeddedCheckoutProtocol+Event.swift, generated) and TypeScript (ProtocolNotifications.ts, generated) get the same treatment — descriptors decode toJSONRPCCheckoutParams/{ checkout }rather thanCheckout.Kits re-narrow to keep their public APIs identical
Swift kit (
CheckoutProtocol.swift):Android kit (
CheckoutProtocol.kt):Web kit (
checkout.ts) narrows at the handler site:The Android kit's public
.apibaseline is unchanged (JVM erasure); the protocol module's.apigains only the two new publicCheckoutParams/ErrorParamsclasses.