Run cherry-picked CI actions on drafts#403
Open
markmur wants to merge 1 commit into
Open
Conversation
eb66e64 to
802abd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Draft PRs previously ran no substantive CI — every job hangs off a
changesdetector that was gated ondraft == false, so only the CLA and team-labeling workflows fired. This wires up a two-tier suite:main) additionally run the expensive macOS/simulator jobs, sample-app builds, breaking-change baselines on macOS, and the dual-build package-size report. These already ran onready_for_review, so nothing new runs at merge time.changesnow always runs and exposes areadyoutput (truefor pushes and non-draft PRs). The two bundled workflows (android-test,swift-lint) gained areadyinput so their expensive sub-jobs split from the cheap ones.ci-requiredstays the single required status check and reports on drafts too — ready-only jobs reportskipped, which it treats as a pass. Every check remains gated by thechangespath filters, so only platforms with relevant file changes run.What runs where
How to test
skippedandCI Requiredstill goes green.main→ unchanged; thereadyoutput istruefor pushes, so everything runs as before.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.