Skip to content

Run cherry-picked CI actions on drafts#403

Open
markmur wants to merge 1 commit into
mainfrom
ci-draft-pr-checks
Open

Run cherry-picked CI actions on drafts#403
markmur wants to merge 1 commit into
mainfrom
ci-draft-pr-checks

Conversation

@markmur

@markmur markmur commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Draft PRs previously ran no substantive CI — every job hangs off a changes detector that was gated on draft == false, so only the CLA and team-labeling workflows fired. This wires up a two-tier suite:

  • Draft PRs now run the fast, cheap Ubuntu lint/test checks for early feedback.
  • Ready PRs (and pushes to main) additionally run the expensive macOS/simulator jobs, sample-app builds, breaking-change baselines on macOS, and the dual-build package-size report. These already ran on ready_for_review, so nothing new runs at merge time.

changes now always runs and exposes a ready output (true for pushes and non-draft PRs). The two bundled workflows (android-test, swift-lint) gained a ready input so their expensive sub-jobs split from the cheap ones. ci-required stays the single required status check and reports on drafts too — ready-only jobs report skipped, which it treats as a pass. Every check remains gated by the changes path filters, so only platforms with relevant file changes run.

What runs where

Check Runner Draft Ready
Web — lint / test / build / verify ubuntu
React Native — lint ubuntu
React Native — Jest tests ubuntu
React Native — packed-files check ubuntu
Android — unit tests ubuntu
Android — lint (detekt + lintRelease) ubuntu
Swift — SwiftLint ubuntu
Swift — sample package paths ubuntu
Breaking changes — Android API baseline ubuntu
Breaking changes — React Native API baseline ubuntu
Android — sample app build ubuntu
React Native — Android tests ubuntu
React Native — Android sample build ubuntu
React Native — iOS tests macOS
React Native — iOS sample build macOS
Swift — package tests macOS
Swift — build sample apps macOS
Swift — SwiftFormat + CocoaPods lint macOS
Breaking changes — Swift API baseline macOS
Package size ubuntu

How to test

  • Open/keep this PR as a draft → only the ✅-Draft checks run; the ready-only jobs report skipped and CI Required still goes green.
  • Mark it ready for review → the full suite runs.
  • Push to main → unchanged; the ready output is true for pushes, so everything runs as before.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 3, 2026
@markmur markmur changed the title Run cherry-picked actions on draft PRs Run cherry-picked actions on draft status Jul 3, 2026
@markmur markmur changed the title Run cherry-picked actions on draft status Run cherry-picked CI actions on drafts Jul 3, 2026
@markmur markmur force-pushed the ci-draft-pr-checks branch from eb66e64 to 802abd4 Compare July 3, 2026 10:22
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
98.5% (263/267) 88.48% (146/165) 100% (58/58)

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@markmur markmur marked this pull request as ready for review July 3, 2026 10:26
@markmur markmur requested a review from a team as a code owner July 3, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant