Skip to content

Move React Native dev commands under root dev.yml#64

Merged
kyle-schellen merged 1 commit into
mainfrom
05-11-move_react_native_dev_commands_under_root_dev.yml
May 13, 2026
Merged

Move React Native dev commands under root dev.yml#64
kyle-schellen merged 1 commit into
mainfrom
05-11-move_react_native_dev_commands_under_root_dev.yml

Conversation

@kyle-schellen
Copy link
Copy Markdown
Contributor

@kyle-schellen kyle-schellen commented May 11, 2026

Refs issue #908.

What changes are you making?

Move platforms/react-native/dev.yml into namespaced commands at the repo
root so dev up and dev react-native <cmd> (or dev rn) work from the
monorepo root. Last in the stack after #35 (Android) and #36 (Swift).

Also addresses review feedback to align RN with the Swift/Android shape:

  • Adds s alias for server
  • Drops the misleading check alias on lint (Android check has a larger surface; RN had no license-header check to back it)
  • Renames fixformat with fix kept as a legacy alias (matches the dev <platform> format convention)
  • Adds dev rn build so all three platforms expose a build subcommand
  • Updates scripts/lint_swift help text to point at the canonical dev react-native format

How to test

From the repo root:

  • dev up completes without error, including Node v22.14.0 / pnpm 10.33.1 setup, RN dependencies, gems, and pods
  • dev rn build builds the @shopify/checkout-kit-react-native module
  • dev rn lint runs SwiftLint/SwiftFormat checks, module lint, and sample lint
  • dev rn style still works as a legacy alias for lint
  • dev rn lint swift, dev rn lint module, and dev rn lint sample scope linting to one area
  • dev rn format auto-fixes Swift lint and format issues (SwiftLint + SwiftFormat)
  • dev rn fix still works as a legacy alias for format
  • dev rn server starts Metro
  • dev rn s still works as a short alias for server
  • dev rn ios runs the iOS sample app
  • dev rn android runs the Android sample app
  • dev rn clean wipes module + sample workspaces and stops sccache

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.53% (214/215) 95.96% (119/124) 100% (64/64)

@kyle-schellen kyle-schellen added the #gsd:50662 Rebase Checkout Kit on UCP label May 11, 2026 — with Graphite App
@kyle-schellen kyle-schellen self-assigned this May 11, 2026
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 48f7c22 to e7c58f1 Compare May 11, 2026 22:25
@kyle-schellen kyle-schellen marked this pull request as ready for review May 11, 2026 22:25
@kyle-schellen kyle-schellen requested a review from a team as a code owner May 11, 2026 22:25
Comment thread dev.yml Outdated
Comment thread dev.yml Outdated
Comment thread dev.yml Outdated
name: Install pods (React Native sample)
met?: (cd platforms/react-native/sample/ios && bundle exec pod check --ignore-dev-pods)
meet: cd platforms/react-native && pnpm run pod-install
- custom:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might be able to remove this one too - now your improvement to the metro bundler has come in, which means we dont have to do the build to see changes, this is less relevant

@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from e7c58f1 to 555e5d6 Compare May 12, 2026 13:58
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from 94fc5d5 to 31fba85 Compare May 12, 2026 14:04
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch 3 times, most recently from f9cf466 to 79b74a1 Compare May 12, 2026 16:37
@kyle-schellen kyle-schellen requested a review from a team as a code owner May 12, 2026 16:37
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from 31fba85 to 92ff28b Compare May 12, 2026 16:37
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 79b74a1 to fa6fa57 Compare May 12, 2026 17:41
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch 2 times, most recently from 8d11dc5 to d26f92e Compare May 12, 2026 18:22
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from fa6fa57 to 87da5c4 Compare May 12, 2026 18:22
@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from d26f92e to 3b360d1 Compare May 12, 2026 21:37
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 87da5c4 to 3604836 Compare May 12, 2026 21:37
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 3604836 to 14080fe Compare May 13, 2026 14:47
Copy link
Copy Markdown
Contributor

@Juanita-Dash Juanita-Dash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyle-schellen kyle-schellen force-pushed the 05-08-move_swift_dev_commands_under_root_dev.yml branch from 3b360d1 to cf9fc4b Compare May 13, 2026 14:54
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 14080fe to a9fdc4f Compare May 13, 2026 14:54
Copy link
Copy Markdown
Contributor Author

kyle-schellen commented May 13, 2026

Merge activity

  • May 13, 3:21 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 13, 3:22 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 13, 3:45 PM UTC: @kyle-schellen merged this pull request with Graphite.

@kyle-schellen kyle-schellen changed the base branch from 05-08-move_swift_dev_commands_under_root_dev.yml to graphite-base/64 May 13, 2026 15:21
@kyle-schellen kyle-schellen changed the base branch from graphite-base/64 to main May 13, 2026 15:21
@kyle-schellen kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from a9fdc4f to b3da179 Compare May 13, 2026 15:22
@kyle-schellen kyle-schellen merged commit 6d58d78 into main May 13, 2026
16 checks passed
@kyle-schellen kyle-schellen deleted the 05-11-move_react_native_dev_commands_under_root_dev.yml branch May 13, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants