Improve linting#243
Conversation
Coverage Report
|
| class RCTShopifyCheckoutSheetKit: RCTEventEmitter, CheckoutDelegate { | ||
| private var hasListeners = false | ||
|
|
||
| internal var checkoutSheet: UIViewController? |
There was a problem hiding this comment.
just to check - was removal of internal intentional?
Wondering if its one of those rules that gave me so much trouble before 😅
There was a problem hiding this comment.
Good catch, this was indeed not intentional. Was there a rule in the swiftlint config for this?
There was a problem hiding this comment.
I'm trying to recall but I think mine were all related to module and extension visibility - not sure which rule has caused this (easiest way to check is re-add the internal and run dev lint check)
I just found this though: https://realm.github.io/SwiftLint/explicit_acl.html which is a rule to explicitly use ACL - might be too heavy handed (haven't seen how much it changes yet) but its the side of things we seem to lean on more
2 participants
What changes are you making?
Allows running
dev checkanddev fixto lint swift code and autofixPR Checklist
Important
Checklist for releasing a new version
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.