Fix stack overflow crash when decoding null values in JSON#560
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Fix stack overflow crash when decoding null values in JSON#560kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
The UnkeyedDecodingContainer.decode([Any].Type) method enters an infinite recursion when encountering JSON null values. None of the type-specific decode attempts (Bool, Double, String, etc.) succeed for null, so isAtEnd never becomes true and the container index never advances, causing a stack overflow. Fix by checking decodeNil() first in both the unkeyed and keyed container extensions. Also add a terminal else-break in the unkeyed loop to prevent infinite loops for any other unexpected value types. Additionally, handle null values in KeyedDecodingContainer.decode( [String: Any].Type) so null dictionary values are preserved as NSNull rather than silently dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UnkeyedDecodingContainer.decode([Any].Type) method enters an infinite recursion when encountering JSON null values. None of the type-specific decode attempts (Bool, Double, String, etc.) succeed for null, so isAtEnd never becomes true and the container index never advances, causing a stack overflow.
Fix by checking decodeNil() first in both the unkeyed and keyed container extensions. Also add a terminal else-break in the unkeyed loop to prevent infinite loops for any other unexpected value types.
Additionally, handle null values in KeyedDecodingContainer.decode( [String: Any].Type) so null dictionary values are preserved as NSNull rather than silently dropped.
What changes are you making?
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.