Fix crash in lazy protocol witness table accessor for type PayWithApplePayButtonLabel on iOS 18#569
Open
fynnrhm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Summary
.applePayLabel(_:)and.applePayStyle(_:)PayWithApplePayButton*toPKPaymentButton*mapping layer and update samples/docsCrash context
This is intended to avoid the iOS 18 cart initialization crash seen while resolving the mapped SwiftUI Apple Pay label/style values:
By accepting
PKPaymentButtonTypeandPKPaymentButtonStyledirectly, the representable receives native PassKit values without the extra computed-property mapping on the SwiftUI types.Verification
scripts/xcode_run test ShopifyCheckoutSheetKit-Package ShopifyAcceleratedCheckoutsTests/ApplePayIntegrationTestsScripts/build_samplesgit diff --checkBefore you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.