-
Notifications
You must be signed in to change notification settings - Fork 254
Expand file tree
/
Copy pathdev-override.test.ts
More file actions
298 lines (259 loc) · 11 KB
/
dev-override.test.ts
File metadata and controls
298 lines (259 loc) · 11 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
import {devWithOverrideFile} from './dev-override.js'
import {openURLSafely} from './dev.js'
import {fetchDevServerSession} from '../utilities/theme-environment/dev-server-session.js'
import {createThemePreview, updateThemePreview} from '../utilities/theme-previews/preview.js'
import {startMockShopPreviewSession} from '../utilities/theme-previews/mock-shop.js'
import {describe, expect, test, vi} from 'vitest'
import {renderSuccess} from '@shopify/cli-kit/node/ui'
import {collectedLogs, clearCollectedLogs} from '@shopify/cli-kit/node/output'
import {fileExistsSync, readFile} from '@shopify/cli-kit/node/fs'
vi.mock('../utilities/theme-environment/dev-server-session.js')
vi.mock('../utilities/theme-previews/preview.js')
vi.mock('../utilities/theme-previews/mock-shop.js')
vi.mock('./dev.js', () => ({openURLSafely: vi.fn()}))
vi.mock('@shopify/cli-kit/node/ui')
vi.mock('@shopify/cli-kit/node/fs')
const adminSession = {token: 'token', storeFqdn: 'store.myshopify.com'}
const mockSession = {
token: 'token',
storeFqdn: 'store.myshopify.com',
storefrontToken: 'sf_token',
sessionCookies: {},
}
const expectedPreviewUrl = 'https://abc123.shopifypreview.com'
const expectedPreviewId = 'abc123'
const mockShopLauncherUrl = 'file:///tmp/mock-shop-preview.html'
const mockShopTargetUrl = 'https://demostore.mock.shop/?theme_preview'
const customMockShopTargetUrl = 'http://localhost:3000/?theme_preview'
describe('devWithOverrideFile', () => {
test('throws when override file does not exist', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(false)
// When/Then
await expect(
devWithOverrideFile({adminSession, overrideJson: '/missing.json', themeId: '123', open: false}),
).rejects.toThrow('Override file not found: /missing.json')
})
test('creates a preview when no previewIdentifier is provided', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(createThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
const expectedThemeId = '789'
// When
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', themeId: expectedThemeId, open: false})
// Then
expect(fetchDevServerSession).toHaveBeenCalledWith(expectedThemeId, adminSession, undefined)
// Then
expect(createThemePreview).toHaveBeenCalledWith(
expect.objectContaining({
session: mockSession,
themeId: expectedThemeId,
}),
)
expect(updateThemePreview).not.toHaveBeenCalled()
expect(renderSuccess).toHaveBeenCalledWith(
expect.objectContaining({
body: [
{
list: {
title: 'Preview is ready',
items: [{link: {url: expectedPreviewUrl}}, `Preview ID: ${expectedPreviewId}`],
},
},
],
}),
)
})
test('updates a preview when previewIdentifier is provided', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(updateThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
const expectedThemeId = '789'
// When
await devWithOverrideFile({
adminSession,
overrideJson: '/overrides.json',
themeId: expectedThemeId,
previewIdentifier: expectedPreviewId,
open: false,
json: false,
})
// Then
expect(updateThemePreview).toHaveBeenCalledWith(
expect.objectContaining({
session: mockSession,
themeId: expectedThemeId,
previewIdentifier: expectedPreviewId,
}),
)
expect(createThemePreview).not.toHaveBeenCalled()
expect(renderSuccess).toHaveBeenCalledWith(
expect.objectContaining({
body: [
{
list: {
title: 'Preview updated',
items: [{link: {url: expectedPreviewUrl}}, `Preview ID: ${expectedPreviewId}`],
},
},
],
}),
)
})
test('throws when override file contains invalid JSON', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from('not valid json'))
// When/Then
const error = await devWithOverrideFile({
adminSession,
overrideJson: '/bad.json',
themeId: '123',
open: false,
json: false,
}).catch((err) => err)
expect(error.message).toBe('Failed to parse override file: /bad.json')
expect(error.tryMessage).toMatch(/not valid json/i)
})
test('opens the preview URL when open is true', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(createThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
// When
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', themeId: '789', open: true})
// Then
expect(openURLSafely).toHaveBeenCalledWith(expectedPreviewUrl, 'theme preview')
})
test('does not open the preview URL when open is false', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(createThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
// When
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', themeId: '789', open: false})
// Then
expect(openURLSafely).not.toHaveBeenCalled()
})
test('passes password to fetchDevServerSession when provided', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(createThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
// When
await devWithOverrideFile({
adminSession,
overrideJson: '/overrides.json',
themeId: '789',
open: false,
json: false,
password: 'shptka_abc123',
})
// Then
expect(fetchDevServerSession).toHaveBeenCalledWith('789', adminSession, 'shptka_abc123')
})
test('outputs JSON when json flag is true', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(createThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
clearCollectedLogs()
// When
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', themeId: '789', open: false, json: true})
// Then
const expectedJson = JSON.stringify({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
expect(collectedLogs.info).toContainEqual(expectedJson)
expect(renderSuccess).not.toHaveBeenCalled()
})
test('renders success body by default when json flag is omitted', async () => {
// Given
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(fetchDevServerSession).mockResolvedValue(mockSession)
vi.mocked(createThemePreview).mockResolvedValue({url: expectedPreviewUrl, preview_identifier: expectedPreviewId})
clearCollectedLogs()
// When
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', themeId: '789', open: false})
// Then
expect(renderSuccess).toHaveBeenCalled()
})
test('starts a one-shot mock.shop preview when mockShop is enabled', async () => {
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(startMockShopPreviewSession).mockResolvedValue({
launcherUrl: mockShopLauncherUrl,
targetUrl: mockShopTargetUrl,
completion: Promise.resolve(),
})
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', open: false, mockShop: true})
expect(startMockShopPreviewSession).toHaveBeenCalledWith(JSON.stringify({templates: {}}), {
storefrontUrl: undefined,
})
expect(fetchDevServerSession).not.toHaveBeenCalled()
expect(createThemePreview).not.toHaveBeenCalled()
expect(updateThemePreview).not.toHaveBeenCalled()
expect(renderSuccess).toHaveBeenCalledWith(
expect.objectContaining({
body: [
{
list: {
title: 'Mock.shop preview is ready',
items: [{link: {url: mockShopLauncherUrl}}, `Target: ${mockShopTargetUrl}`, 'This prototype opens an initial preview only.'],
},
},
],
}),
)
})
test('opens the launcher URL for a mock.shop preview', async () => {
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(startMockShopPreviewSession).mockResolvedValue({
launcherUrl: mockShopLauncherUrl,
targetUrl: mockShopTargetUrl,
completion: Promise.resolve(),
})
await devWithOverrideFile({adminSession, overrideJson: '/overrides.json', open: true, mockShop: true})
expect(openURLSafely).toHaveBeenCalledWith(mockShopLauncherUrl, 'mock.shop preview')
})
test('passes through a custom storefront URL in mock.shop mode', async () => {
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
vi.mocked(startMockShopPreviewSession).mockResolvedValue({
launcherUrl: mockShopLauncherUrl,
targetUrl: customMockShopTargetUrl,
completion: Promise.resolve(),
})
await devWithOverrideFile({
adminSession,
overrideJson: '/overrides.json',
open: false,
mockShop: true,
mockShopStorefrontUrl: 'http://localhost:3000',
})
expect(startMockShopPreviewSession).toHaveBeenCalledWith(JSON.stringify({templates: {}}), {
storefrontUrl: 'http://localhost:3000',
})
})
test('rejects preview IDs in mock.shop mode', async () => {
vi.mocked(fileExistsSync).mockReturnValue(true)
vi.mocked(readFile).mockResolvedValue(Buffer.from(JSON.stringify({templates: {}})))
await expect(
devWithOverrideFile({
adminSession,
overrideJson: '/overrides.json',
open: false,
mockShop: true,
previewIdentifier: 'abc123',
}),
).rejects.toThrow('The --preview-id flag is not supported with --mock-shop.')
})
})