Skip to content

Commit 06513a0

Browse files
Merge pull request #6849 from Shopify/shauns/02-11-use_main-cli_and_javascript-cli_branches_for_react-router_template
Use main-cli and javascript-cli branches for react-router template
2 parents 8b23d43 + c0c24c5 commit 06513a0

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/app/src/cli/prompts/init/init.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ describe('init', () => {
3939

4040
test('it renders branches for templates that have them', async () => {
4141
const answers = {
42-
template: 'https://github.com/Shopify/shopify-app-template-react-router#javascript',
42+
template: 'https://github.com/Shopify/shopify-app-template-react-router#javascript-cli',
4343
}
4444
const options: InitOptions = {}
4545

4646
// Given
4747
vi.mocked(renderSelectPrompt).mockResolvedValueOnce('reactRouter')
48-
vi.mocked(renderSelectPrompt).mockResolvedValueOnce('javascript')
48+
vi.mocked(renderSelectPrompt).mockResolvedValueOnce('javascript-cli')
4949

5050
// When
5151
const got = await init(options)
@@ -61,8 +61,8 @@ describe('init', () => {
6161
})
6262
expect(renderSelectPrompt).toHaveBeenCalledWith({
6363
choices: [
64-
{label: 'JavaScript', value: 'javascript'},
65-
{label: 'TypeScript', value: 'main'},
64+
{label: 'JavaScript', value: 'javascript-cli'},
65+
{label: 'TypeScript', value: 'main-cli'},
6666
],
6767
message: 'For your React Router template, which language do you want?',
6868
})

packages/app/src/cli/prompts/init/init.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ export const templates = {
3838
branches: {
3939
prompt: 'For your React Router template, which language do you want?',
4040
options: {
41-
javascript: {branch: 'javascript', label: 'JavaScript'},
42-
typescript: {branch: 'main', label: 'TypeScript'},
41+
javascript: {branch: 'javascript-cli', label: 'JavaScript'},
42+
typescript: {branch: 'main-cli', label: 'TypeScript'},
4343
},
4444
},
4545
} as Template,

0 commit comments

Comments
 (0)