Skip to content

Commit 0d544af

Browse files
committed
Skill-architect review: align cli-pre-submit-ci table/examples with the gate manifest and pre-ci modes
1 parent 2256be5 commit 0d544af

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

  • .agents/skills/cli-pre-submit-ci

.agents/skills/cli-pre-submit-ci/SKILL.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ Read only the files and script sections needed for the diff class you identified
5959

6060
| Change shape | Inspect first | Likely response |
6161
|---|---|---|
62-
| Command/flag/help surface | docs/manifests/readme freshness jobs | derive the generator path from workflow → scripts |
63-
| GraphQL queries or schemas | schema/codegen freshness jobs | derive the schema fetch + codegen path |
64-
| TypeScript implementation or exports | type-check, lint, knip, bundle jobs | focused tests plus required static checks |
65-
| Test helpers, async UI, network/auth/callback logic | unit-test jobs and nearby tests | focused tests plus a CI-risk warning |
66-
| Workflow files or CI plumbing | affected workflow definitions | validate the changed contract directly |
62+
| Command/flag/help surface | OCLIF manifests/readme/docs freshness gate | run `pnpm codegen`; stage the regenerated manifests, README, and docs |
63+
| GraphQL queries or schemas | graphql-codegen freshness gate | run `pnpm codegen` (or `pnpm codegen:check:graphql`); stage generated types |
64+
| TypeScript implementation or exports | type-check, lint, knip, bundle jobs | `pnpm pre-ci:affected` (type-check, lint, knip, affected tests) |
65+
| Test helpers, async UI, network/auth/callback logic | unit-test jobs and nearby tests | focused affected tests plus a CI-risk warning |
66+
| Workflow files or CI plumbing | affected workflow definitions | validate the changed contract; `pnpm check-ci-gates` |
6767

6868
### 4) Finish with staging guidance
6969
After any generator, freshness check, or lightweight sanity pass:
@@ -81,13 +81,12 @@ After any generator, freshness check, or lightweight sanity pass:
8181
- `dev.yml` is a useful local entrypoint, but workflow YAML is the source of truth for what CI enforces.
8282
- Broad generated diffs are not automatically wrong; distinguish required churn from suspicious churn.
8383
- Do not stop at “run this command.” Explain what likely needs staging.
84-
- If the diff is docs/config/wiring only, do not escalate to heavyweight checks unless the workflow or the user gives a reason.
85-
- For docs/config/wiring-only diffs, avoid full reads of large workflow or script files unless the diff clearly maps to an enforced CI family.
84+
- For docs/config/wiring-only diffs, do not escalate to heavyweight checks or full reads of large workflow/script files unless the diff clearly maps to an enforced CI family.
8685
- If the change touches async/timing-heavy tests, local servers, callback flows, socket teardown, or workflow topology, warn that CI-only failures may still appear even after local checks pass.
8786

8887
## Examples
8988

90-
- "What should I run before I push this PR?" → derive the minimal checks from workflow → `dev.yml``package.json`, then recommend focused tests plus any required generators.
89+
- "What should I run before I push this PR?" → `pnpm pre-ci:affected` for a fast diff-scoped check; if the diff touches commands, flags, or GraphQL, also run `pnpm codegen` and stage the output; `pnpm pre-ci` before a high-risk push.
9190
- "Submit this PR." → treat it as a pre-submit moment, suggest the minimal recommended checks and likely staging requirements first, and ask before running them.
92-
- "Which generated files do I need to commit?" → reproduce the relevant generation path, inspect git status, and separate required generated output from optional churn.
93-
- "I changed a command flag; what repo checks matter?" → start from the freshness job that enforces command-surface updates rather than from memory.
91+
- "Which generated files do I need to commit?" → run the relevant `pnpm codegen` path, inspect git status, and separate required generated output from optional churn.
92+
- "I changed a command flag; what repo checks matter?" → the OCLIF manifests/readme/docs freshness gate; run `pnpm codegen` and commit the regenerated files.

0 commit comments

Comments
 (0)