Skip to content

Commit 11a9ece

Browse files
committed
fix lint issues
1 parent e839a00 commit 11a9ece

4 files changed

Lines changed: 9 additions & 15 deletions

File tree

packages/e2e/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
},
3131
"devDependencies": {
3232
"@playwright/test": "^1.50.0",
33+
"@shopify/cli-kit": "3.92.0",
3334
"@types/node": "18.19.70",
3435
"execa": "^7.2.0",
3536
"node-pty": "^1.0.0",

packages/e2e/setup/auth.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable no-restricted-imports */
21
import {cliFixture} from './cli.js'
32
import {executables} from './env.js'
43
import {stripAnsi} from '../helpers/strip-ansi.js'

packages/e2e/tests/app-basic.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import {appScaffoldFixture as test} from '../setup/app.js'
22
import {requireEnv} from '../setup/env.js'
33
import {expect} from '@playwright/test'
4-
import {writeFileSync} from 'node:fs'
5-
import {join} from 'node:path'
4+
import {joinPath} from '@shopify/cli-kit/node/path'
5+
import * as fs from 'fs'
66

77
test.describe('App basic flow (no extensions)', () => {
88
test('init, dev, execute, quit, clean, deploy, versions, config link, deploy to secondary', async ({
@@ -85,8 +85,8 @@ test.describe('App basic flow (no extensions)', () => {
8585
// causes renderTextPrompt to return '' → filenameFromName('') = 'shopify.app.toml' →
8686
// that file already exists → overwrite confirmation prompt hangs.
8787
// (--config and --client-id are mutually exclusive flags, so we can't pass both directly.)
88-
writeFileSync(
89-
join(appScaffold.appDir, 'shopify.app.secondary.toml'),
88+
fs.writeFileSync(
89+
joinPath(appScaffold.appDir, 'shopify.app.secondary.toml'),
9090
`client_id = "${env.secondaryClientId}"\n`,
9191
)
9292

pnpm-lock.yaml

Lines changed: 4 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)