Merge pull request #7013 from Shopify/smaller-bundle

Smaller bundle

Author: gonzaloriestra

package.json

@@ -147,10 +147,7 @@
     "ignoreBinaries": [
       "playwright"
     ],
-    "ignoreDependencies": [
-      "@shopify/theme-check-node",
-      "@shopify/theme-check-docs-updater"
-    ],
+    "ignoreDependencies": [],
     "ignoreWorkspaces": [
       "packages/eslint-plugin-cli",
       "packages/e2e"
@@ -199,6 +196,7 @@
           "**/graphql/**/generated/*.ts"
         ],
         "ignoreDependencies": [
+          "@graphql-typed-document-node/core",
           "@shopify/plugin-cloudflare"
         ],
         "vite": {
@@ -215,7 +213,9 @@
         ],
         "project": "**/*.ts!",
         "ignoreDependencies": [
-          "@ast-grep/napi"
+          "@ast-grep/napi",
+          "@shopify/theme-check-docs-updater",
+          "@shopify/theme-check-node"
         ],
         "vite": {
           "config": [
@@ -288,6 +288,9 @@
         "ignoreBinaries": [
           "open"
         ],
+        "ignoreDependencies": [
+          "@graphql-typed-document-node/core"
+        ],
         "vite": {
           "config": [
             "vite.config.ts"
@@ -306,10 +309,7 @@
           "**/scripts/*.ts!",
           "**/src/testing/index.ts"
         ],
-        "project": "**/*.{ts,tsx}!",
-        "ignoreDependencies": [
-          "react-dom"
-        ]
+        "project": "**/*.{ts,tsx}!"
       },
       "packages/ui-extensions-test-utils": {
         "entry": [

packages/cli-kit/package.json

@@ -120,7 +120,7 @@
     "ansi-escapes": "6.2.1",
     "archiver": "5.3.2",
     "bottleneck": "2.19.5",
-    "brotli": "1.3.3",
+
     "chalk": "5.4.1",
     "change-case": "4.1.2",
     "color-json": "3.0.5",
@@ -168,7 +168,7 @@
     "zod": "3.24.4"
   },
   "devDependencies": {
-    "@types/brotli": "^1.3.4",
+
     "@types/commondir": "^1.0.0",
     "@types/diff": "^5.2.3",
     "@types/fs-extra": "9.0.13",

packages/cli-kit/src/public/node/archiver.integration.test.ts

@@ -4,7 +4,7 @@ import {joinPath, dirname} from './path.js'
 import {exec} from './system.js'
 import {describe, expect, test} from 'vitest'
 import StreamZip from 'node-stream-zip'
-import brotli from 'brotli'
+import {brotliDecompressSync} from 'zlib'
 
 import fs from 'fs'
 
@@ -92,8 +92,8 @@ describe('brotliCompress', () => {
       // Brotli files start with the bytes 0x1B...
       expect(compressedContent[0]).toBe(0x1b)
 
-      // Decompress using brotli library
-      const decompressed = brotli.decompress(compressedContent)
+      // Decompress using native zlib brotli
+      const decompressed = brotliDecompressSync(compressedContent)
       expect(decompressed).toBeTruthy()
     })
   })
@@ -125,7 +125,7 @@ describe('brotliCompress', () => {
 
       // Save compressed content to a file
       const compressedContent = fs.readFileSync(brotliPath)
-      const decompressed = brotli.decompress(compressedContent)
+      const decompressed = brotliDecompressSync(compressedContent)
       const tmpTarPath = joinPath(tmpDir, 'output.tar')
       fs.writeFileSync(tmpTarPath, decompressed)
 

packages/cli-kit/src/public/node/archiver.ts

@@ -6,6 +6,7 @@ import {createWriteStream, readFileSync, writeFileSync} from 'fs'
 import {readFile} from 'fs/promises'
 import {tmpdir} from 'os'
 import {randomUUID} from 'crypto'
+import {brotliCompressSync, constants as zlibConstants} from 'zlib'
 
 interface ZipOptions {
   /**
@@ -183,16 +184,13 @@ export async function brotliCompress(options: BrotliOptions): Promise<void> {
     })
 
     const tarContent = readFileSync(tempTarPath)
-    const brotli = await import('brotli')
-    const compressed = brotli.default.compress(tarContent, {
-      quality: 7,
-      mode: 0,
+    const compressed = brotliCompressSync(tarContent, {
+      params: {
+        [zlibConstants.BROTLI_PARAM_QUALITY]: 7,
+        [zlibConstants.BROTLI_PARAM_MODE]: zlibConstants.BROTLI_MODE_GENERIC,
+      },
     })
 
-    if (!compressed) {
-      throw new Error('Brotli compression failed')
-    }
-
     writeFileSync(options.outputPath, compressed)
   } finally {
     try {

packages/cli/bin/bundle.js

@@ -40,7 +40,7 @@ const hydrogenAssets = joinPath(hydrogenPath, 'dist/assets/hydrogen/**/*')
 
 esBuild({
   bundle: true,
-  entryPoints: ['./src/**/*.ts'],
+  entryPoints: ['./src/index.ts', './src/hooks/prerun.ts', './src/hooks/postrun.ts'],
   outdir: './dist',
   platform: 'node',
   format: 'esm',
@@ -53,14 +53,14 @@ esBuild({
   },
   inject: ['../../bin/bundling/cjs-shims.js'],
   external,
-  sourcemap: true,
+  sourcemap: 'external',
   loader: {'.node': 'copy'},
   splitting: true,
   // these tree shaking and minify options remove any in-source tests from the bundle
   treeShaking: true,
-  minifyWhitespace: false,
+  minifyWhitespace: true,
   minifySyntax: true,
-  minifyIdentifiers: false,
+  minifyIdentifiers: true,
 
   plugins: [
     ShopifyVSCodePlugin,

packages/cli/package.json

@@ -38,6 +38,7 @@
     "/bin/run.cmd",
     "/bin/run.js",
     "/dist",
+    "!/dist/**/*.map",
     "/oclif.manifest.json"
   ],
   "scripts": {