Merge pull request #6807 from Shopify/fix-unknown-user-id-in-observe

Avoid sending 'unknown' to Observe as the user ID

Author: gonzaloriestra

packages/cli-kit/src/public/node/error-handler.test.ts

@@ -263,7 +263,7 @@ describe('sends errors to Bugsnag', () => {
     expect(capturedEventHandler).toHaveBeenCalled()
 
     const mockEvent = capturedEventHandler.mock.calls[0]![0]
-    expect(mockEvent.setUser).toHaveBeenCalledWith('unknown')
+    expect(mockEvent.setUser).toHaveBeenCalledWith(undefined)
   })
 
   test('attaches custom metadata with allowed slice_name when startCommand is present', async () => {

packages/cli-kit/src/public/node/error-handler.ts

@@ -126,7 +126,11 @@ export async function sendErrorToBugsnag(
 
     if (report) {
       initializeBugsnag()
-      const userId = await getLastSeenUserIdAfterAuth()
+      let userId: string | undefined = await getLastSeenUserIdAfterAuth()
+      if (userId === 'unknown') {
+        // Observe will use the IP when undefined
+        userId = undefined
+      }
       await new Promise((resolve, reject) => {
         outputDebug(`Reporting ${unhandled ? 'unhandled' : 'handled'} error to Bugsnag: ${reportableError.message}`)
         const eventHandler = (event: Event) => {