Merge pull request #7570 from Shopify/jules-refactor-extract-name-families-5000229121639096699

[Refactor] Extract NAME_FAMILIES constant from getRandomName

Author: gonzaloriestra

.jules/refactor.md

@@ -161,24 +161,25 @@ const SAFE_RANDOM_CREATIVE_NOUNS = [
 
 export type RandomNameFamily = 'business' | 'creative'
 
+const NAME_FAMILIES: Record<RandomNameFamily, {adjectives: string[]; nouns: string[]}> = {
+  business: {
+    adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES,
+    nouns: SAFE_RANDOM_BUSINESS_NOUNS,
+  },
+  creative: {
+    adjectives: SAFE_RANDOM_CREATIVE_ADJECTIVES,
+    nouns: SAFE_RANDOM_CREATIVE_NOUNS,
+  },
+}
+
 /**
  * Generates a random name by combining an adjective and noun.
  *
  * @param family - Theme to use for the random name (business or creative).
  * @returns A random name generated by combining an adjective and noun.
  */
 export function getRandomName(family: RandomNameFamily = 'business'): string {
-  const mapping = {
-    business: {
-      adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES,
-      nouns: SAFE_RANDOM_BUSINESS_NOUNS,
-    },
-    creative: {
-      adjectives: SAFE_RANDOM_CREATIVE_ADJECTIVES,
-      nouns: SAFE_RANDOM_CREATIVE_NOUNS,
-    },
-  }
-  return `${takeRandomFromArray(mapping[family].adjectives)}-${takeRandomFromArray(mapping[family].nouns)}`
+  return `${takeRandomFromArray(NAME_FAMILIES[family].adjectives)}-${takeRandomFromArray(NAME_FAMILIES[family].nouns)}`
 }
 
 /**