Commit 3f7b6f1
committed
Fix Windows path mismatch and clean up map on unlink
Two review-comment fixes from #7491:
- shouldIgnoreEvent looked up event.path raw, but extensionWatchedFiles
is keyed by normalizePath(file). On Windows, chokidar emits
backslash-separated paths and the lookup would miss, causing
runtime-discovered files to be re-filtered by the static-list check.
Normalize before the lookup.
- Runtime discovery added entries to extensionWatchedFiles but never
removed them on unlink. In a long-running dev session the map grew
unbounded with stale ownership data. Delete the normalized path from
the map after pushing file_deleted; subsequent timeouts for other
handles are no-ops on the now-missing key.1 parent 2ef08a3 commit 3f7b6f1
1 file changed
Lines changed: 10 additions & 1 deletion
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
230 | 235 | | |
231 | 236 | | |
232 | 237 | | |
| |||
387 | 392 | | |
388 | 393 | | |
389 | 394 | | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
390 | 399 | | |
391 | 400 | | |
392 | 401 | | |
| |||
0 commit comments