Skip to content

Commit 759b94a

Browse files
Merge pull request #7532 from Shopify/remove-fs-mock-execute-operation-test-7362924430070990755
[Tests] Remove filesystem mocks in execute-operation.test.ts
2 parents a2ab64e + 5846d4b commit 759b94a

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

packages/app/src/cli/services/execute-operation.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,14 @@ import {OrganizationApp, OrganizationSource, OrganizationStore} from '../models/
44
import {renderSuccess, renderError, renderSingleTask} from '@shopify/cli-kit/node/ui'
55
import {adminRequestDoc} from '@shopify/cli-kit/node/api/admin'
66
import {ClientError} from 'graphql-request'
7-
import {inTemporaryDirectory, writeFile} from '@shopify/cli-kit/node/fs'
7+
import {inTemporaryDirectory, writeFile, readFile} from '@shopify/cli-kit/node/fs'
88
import {joinPath} from '@shopify/cli-kit/node/path'
99
import {mockAndCaptureOutput} from '@shopify/cli-kit/node/testing/output'
1010
import {describe, test, expect, vi, beforeEach, afterEach} from 'vitest'
1111

1212
vi.mock('./graphql/common.js')
1313
vi.mock('@shopify/cli-kit/node/ui')
1414
vi.mock('@shopify/cli-kit/node/api/admin')
15-
vi.mock('@shopify/cli-kit/node/fs')
1615

1716
describe('executeOperation', () => {
1817
const mockOrganization = {
@@ -219,7 +218,6 @@ describe('executeOperation', () => {
219218

220219
const expectedOutput = JSON.stringify(mockResult, null, 2)
221220
expect(mockOutput.info()).toContain(expectedOutput)
222-
expect(writeFile).not.toHaveBeenCalled()
223221
})
224222

225223
test('writes results to file when outputFile is provided', async () => {
@@ -238,7 +236,7 @@ describe('executeOperation', () => {
238236
})
239237

240238
const expectedContent = JSON.stringify(mockResult, null, 2)
241-
expect(writeFile).toHaveBeenCalledWith(outputFile, expectedContent)
239+
await expect(readFile(outputFile)).resolves.toBe(expectedContent)
242240
expect(renderSuccess).toHaveBeenCalledWith(
243241
expect.objectContaining({
244242
body: expect.stringContaining(outputFile),

0 commit comments

Comments
 (0)