Skip to content

Commit 7fd3ee7

Browse files
Merge pull request #7350 from Shopify/psyw-0420-E2E-try-more-workers-and-add-shards
E2E: trial for more workers + shards
2 parents 22b5d32 + caa8bde commit 7fd3ee7

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/tests-pr.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,11 +216,15 @@ jobs:
216216
run: exit 1
217217

218218
e2e-tests:
219-
name: 'E2E tests'
219+
name: "E2E tests (shard ${{ matrix.shard }})"
220220
if: github.event.pull_request.head.repo.full_name == github.repository
221221
runs-on: ubuntu-latest
222222
timeout-minutes: 20
223223
continue-on-error: true
224+
strategy:
225+
fail-fast: false
226+
matrix:
227+
shard: ['1/2', '2/2']
224228
steps:
225229
- uses: actions/checkout@v3
226230
with:
@@ -245,19 +249,19 @@ jobs:
245249
E2E_ACCOUNT_PASSWORD: ${{ secrets.E2E_ACCOUNT_PASSWORD }}
246250
E2E_STORE_FQDN: ${{ secrets.E2E_STORE_FQDN }}
247251
E2E_ORG_ID: ${{ secrets.E2E_ORG_ID }}
248-
run: pnpm exec playwright test
252+
run: pnpm exec playwright test --shard ${{ matrix.shard }}
249253
- name: Upload Playwright report
250254
uses: actions/upload-artifact@v4
251255
if: ${{ !cancelled() }}
252256
with:
253-
name: playwright-report
257+
name: playwright-report-${{ strategy.job-index }}
254258
path: packages/e2e/playwright-report/
255259
retention-days: 14
256260
- name: Upload test results
257261
uses: actions/upload-artifact@v4
258262
if: ${{ !cancelled() }}
259263
with:
260-
name: playwright-results
264+
name: playwright-results-${{ strategy.job-index }}
261265
path: packages/e2e/test-results/
262266
retention-days: 14
263267

packages/e2e/playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default defineConfig({
1313
fullyParallel: true,
1414
forbidOnly: isCI,
1515
retries: 0,
16-
workers: 5,
16+
workers: 10,
1717
maxFailures: isCI ? 3 : 0, // Stop early in CI after 3 failures
1818
reporter: isCI ? [['html', {open: 'never'}], ['list']] : [['list']],
1919
timeout: TEST_TIMEOUT.default, // Heavy tests override via test.setTimeout()

0 commit comments

Comments
 (0)