Skip to content

Commit 8675dae

Browse files
authored
Merge pull request #7111 from Shopify/03-26-refactor_remotespecification
Refactor RemoteSpecification
2 parents e8bdb75 + 707e8c2 commit 8675dae

12 files changed

Lines changed: 186 additions & 267 deletions

File tree

packages/app/src/cli/api/graphql/extension_specifications.ts

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,22 @@ export interface ExtensionSpecificationsQueryVariables {
3131
}
3232

3333
export interface RemoteSpecification {
34+
name: string
35+
externalName: string
36+
identifier: string
37+
gated: boolean
38+
externalIdentifier: string
39+
experience: 'extension' | 'configuration' | 'deprecated'
40+
managementExperience: 'cli' | 'custom' | 'dashboard'
41+
registrationLimit: number
42+
uidStrategy: 'single' | 'dynamic' | 'uuid'
43+
surface?: string
44+
validationSchema?: {
45+
jsonSchema: string
46+
} | null
47+
}
48+
49+
interface PartnersRemoteSpecification {
3450
name: string
3551
externalName: string
3652
identifier: string
@@ -40,8 +56,6 @@ export interface RemoteSpecification {
4056
options: {
4157
managementExperience: 'cli' | 'custom' | 'dashboard'
4258
registrationLimit: number
43-
uidIsClientProvided: boolean
44-
uidStrategy?: 'single' | 'dynamic' | 'uuid'
4559
}
4660
features?: {
4761
argo?: {
@@ -53,11 +67,6 @@ export interface RemoteSpecification {
5367
} | null
5468
}
5569

56-
export interface FlattenedRemoteSpecification extends RemoteSpecification {
57-
surface?: string
58-
registrationLimit: number
59-
}
60-
6170
export interface ExtensionSpecificationsQuerySchema {
62-
extensionSpecifications: RemoteSpecification[]
71+
extensionSpecifications: PartnersRemoteSpecification[]
6372
}

0 commit comments

Comments
 (0)