Remove deprecated --type flag from shopify app generate extension

The --type (-t) flag and SHOPIFY_FLAG_EXTENSION_TYPE env var on
`shopify app generate extension` were deprecated in favor of --template
(SHOPIFY_FLAG_EXTENSION_TEMPLATE). This change removes them along with
the deprecation warning. The -t short flag now maps to --template, which
was previously shadowed by the --type registration.

Author: alfonso-noriega

.changeset/remove-app-generate-extension-type-flag.md

@@ -0,0 +1,5 @@
+---
+'@shopify/app': major
+---
+
+Remove the deprecated `--type` (`-t`) flag and `SHOPIFY_FLAG_EXTENSION_TYPE` environment variable from `shopify app generate extension`. Use `--template` (`SHOPIFY_FLAG_EXTENSION_TEMPLATE`) instead.

docs-shopify.dev/commands/interfaces/app-generate-extension.interface.ts

@@ -52,12 +52,6 @@ export interface appgenerateextension {
    */
   '-t, --template <value>'?: string
 
-  /**
-   * Deprecated. Please use --template
-   * @environment SHOPIFY_FLAG_EXTENSION_TYPE
-   */
-  '-t, --type <value>'?: string
-
   /**
    * Increase the verbosity of the output.
    * @environment SHOPIFY_FLAG_VERBOSE

packages/app/src/cli/commands/app/generate/extension.ts

@@ -6,7 +6,6 @@ import AppLinkedCommand, {AppLinkedCommandOutput} from '../../../utilities/app-l
 import {linkedAppContext} from '../../../services/app-context.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
-import {renderWarning} from '@shopify/cli-kit/node/ui'
 
 export default class AppGenerateExtension extends AppLinkedCommand {
   static summary = 'Generate a new app Extension.'
@@ -21,12 +20,6 @@ export default class AppGenerateExtension extends AppLinkedCommand {
   static flags = {
     ...globalFlags,
     ...appFlags,
-    type: Flags.string({
-      char: 't',
-      hidden: false,
-      description: `Deprecated. Please use --template`,
-      env: 'SHOPIFY_FLAG_EXTENSION_TYPE',
-    }),
     template: Flags.string({
       char: 't',
       hidden: false,
@@ -67,14 +60,6 @@ export default class AppGenerateExtension extends AppLinkedCommand {
       cmd_scaffold_type_owner: '@shopify/app',
     }))
 
-    if (flags.type) {
-      renderWarning({
-        headline: ['The flag --type has been deprecated in favor of --template.'],
-        body: ['Please use --template instead.'],
-      })
-      process.exit(2)
-    }
-
     await checkFolderIsValidApp(flags.path)
 
     const {app, project, specifications, remoteApp, developerPlatformClient} = await linkedAppContext({

packages/cli/README.md

@@ -722,13 +722,12 @@ Generate a new app Extension.
 USAGE
   $ shopify app generate extension [--client-id <value> | -c <value>] [--flavor
     vanilla-js|react|typescript|typescript-react|wasm|rust] [-n <value>] [--no-color] [--path <value>] [--reset | ] [-t
-    <value>] [-t <value>] [--verbose]
+    <value>] [--verbose]
 
 FLAGS
   -c, --config=<value>     [env: SHOPIFY_FLAG_APP_CONFIG] The name of the app configuration.
   -n, --name=<value>       [env: SHOPIFY_FLAG_NAME] name of your Extension
   -t, --template=<value>   [env: SHOPIFY_FLAG_EXTENSION_TEMPLATE] Extension template
-  -t, --type=<value>       [env: SHOPIFY_FLAG_EXTENSION_TYPE] Deprecated. Please use --template
       --client-id=<value>  [env: SHOPIFY_FLAG_CLIENT_ID] The Client ID of your app.
       --flavor=<option>    [env: SHOPIFY_FLAG_FLAVOR] Choose a starting template for your extension, where applicable
                            <options: vanilla-js|react|typescript|typescript-react|wasm|rust>

packages/cli/oclif.manifest.json

@@ -2124,16 +2124,6 @@
           "name": "template",
           "type": "option"
         },
-        "type": {
-          "char": "t",
-          "description": "Deprecated. Please use --template",
-          "env": "SHOPIFY_FLAG_EXTENSION_TYPE",
-          "hasDynamicHelp": false,
-          "hidden": false,
-          "multiple": false,
-          "name": "type",
-          "type": "option"
-        },
         "verbose": {
           "allowNo": false,
           "description": "Increase the verbosity of the output.",