Skip to content

Commit 93c70f4

Browse files
isaacroldanclaude
andcommitted
Add store to manifest regen, soften repo-health matchers
Store package ships /oclif.manifest.json but the prepack didn't regenerate it — same bug the test is meant to catch. Add `pnpm oclif manifest` to store's prepack alongside the other six packages. Per Copilot review feedback, soften the repo-health matchers so the test doesn't miss legitimate variants: - files entries: match any path ending in `oclif.manifest.json` (covers `'oclif.manifest.json'` and globs in addition to `'/oclif.manifest.json'`) - prepack script: match `oclif manifest` via word-boundary regex (covers `pnpm exec oclif manifest`, `pnpm --silent oclif manifest`, etc.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 576c952 commit 93c70f4

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

packages/cli/src/cli/repo-health.test.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,11 @@ describe('oclif manifest packaging', () => {
122122
scripts?: {prepack?: string}
123123
}
124124

125-
if (!packageJson.files?.includes('/oclif.manifest.json')) continue
126-
if (!packageJson.scripts?.prepack?.includes('pnpm oclif manifest')) {
125+
const shipsOclifManifest = packageJson.files?.some((file) =>
126+
file.replace(/^\.?\//, '').endsWith('oclif.manifest.json'),
127+
)
128+
if (!shipsOclifManifest) continue
129+
if (!/\boclif\s+manifest\b/.test(packageJson.scripts?.prepack ?? '')) {
127130
missingManifestRefresh.push(path.relative(repoRoot, packageJsonPath))
128131
}
129132
}

packages/store/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"clean": "nx clean",
3131
"lint": "nx lint",
3232
"lint:fix": "nx lint:fix",
33-
"prepack": "NODE_ENV=production pnpm nx build && cp ../../README.md README.md",
33+
"prepack": "NODE_ENV=production pnpm nx build && pnpm oclif manifest && cp ../../README.md README.md",
3434
"vitest": "vitest",
3535
"type-check": "nx type-check"
3636
},

0 commit comments

Comments
 (0)