Skip to content

Commit a1095cb

Browse files
ryancbahanclaude
andcommitted
Address PR review feedback on TOML config tests
Remove invalid-prefix.toml and unknown-section.toml fixtures that don't actually test client-side validation (prefix isn't validated, unknown sections pass through via .passthrough()). Add error message assertion to invalid TOML tests, bump dev test timeout to 6 min, and make quit-key assertion more specific. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 45688be commit a1095cb

4 files changed

Lines changed: 3 additions & 21 deletions

File tree

packages/e2e/data/invalid-tomls/invalid-prefix.toml

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/e2e/data/invalid-tomls/unknown-section.toml

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/e2e/tests/toml-config-invalid.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ test.describe('TOML config invalid', () => {
3737
const output = result.stdout + result.stderr
3838
console.log(`[${label}] exit code: ${result.exitCode}\n[${label}] output:\n${output}`)
3939
expect(result.exitCode, `expected deploy to fail for ${label}, but it succeeded:\n${output}`).not.toBe(0)
40+
expect(output.toLowerCase(), `expected error output for ${label}:\n${output}`).toMatch(/error|invalid|failed/)
4041
} finally {
4142
fs.rmSync(appDir, {recursive: true, force: true})
4243
}

packages/e2e/tests/toml-config.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ test.describe('TOML config regression', () => {
1515
})
1616

1717
test('dev starts with fully populated toml', async ({cli, env, tomlAppDir}) => {
18-
test.setTimeout(5 * 60 * 1000)
18+
test.setTimeout(6 * 60 * 1000)
1919
requireEnv(env, 'clientId', 'storeFqdn')
2020

2121
const proc = await cli.spawn(['app', 'dev', '--path', tomlAppDir], {
@@ -26,7 +26,7 @@ test.describe('TOML config regression', () => {
2626
await proc.waitForOutput('Ready, watching for changes in your app', 3 * 60 * 1000)
2727

2828
const output = proc.getOutput()
29-
expect(output).toContain('q')
29+
expect(output).toMatch(/q\s*[|]\s*quit/i)
3030

3131
proc.sendKey('q')
3232
const exitCode = await proc.waitForExit(30_000)

0 commit comments

Comments
 (0)