Merge pull request #7468 from Shopify/remove-fake-approval-gate

Remove unused 'Breaking change approval' job

Author: alfonso-noriega

.github/workflows/tests-pr.yml

@@ -333,16 +333,5 @@ jobs:
       - name: Fail if breaking changes detected
         if: steps.check.outputs.has_breaking_changes == 'true'
         run: |
-          echo '::error::Breaking changes detected. A member of @shopify/dev_experience must approve the breaking-change-approval environment.'
+          echo '::error::Breaking changes detected. See the sticky comment on the PR for details.'
           exit 1
-
-  major-change-approval:
-    name: 'Breaking change approval'
-    needs: major-change-check
-    if: always() && needs.major-change-check.outputs.has_breaking_changes == 'true'
-    runs-on: ubuntu-latest
-    timeout-minutes: 5
-    environment: breaking-change-approval
-    steps:
-      - name: Approved
-        run: echo '✅ Breaking changes approved by dev_experience team member'

workspace/src/major-change-check.js

@@ -571,9 +571,7 @@ function buildReport({majorChangesets, manifestChanges, schemaChanges}) {
 
 This PR contains changes that may break the existing contract.
 
-**@shopify/dev_experience** — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run.
-
-> 💬 Head to [#help-dev-platform](https://shopify.enterprise.slack.com/archives/C07UJ7UNMTK) to discuss timing and plan the release.
+**@shopify/dev_experience** — this PR contains breaking changes that require coordination for the next major release.
 
 `