Skip to content

Commit d108925

Browse files
authored
Merge pull request #7175 from Shopify/04-02-remove-otel-semantic-conventions
Remove @opentelemetry/semantic-conventions dependency
2 parents bc6e197 + c7a91c0 commit d108925

3 files changed

Lines changed: 1 addition & 6 deletions

File tree

packages/cli-kit/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@
113113
"@opentelemetry/exporter-metrics-otlp-http": "0.57.0",
114114
"@opentelemetry/resources": "1.30.0",
115115
"@opentelemetry/sdk-metrics": "1.30.0",
116-
"@opentelemetry/semantic-conventions": "1.28.0",
117116
"@types/archiver": "5.3.2",
118117
"ajv": "8.18.0",
119118
"ansi-escapes": "6.2.1",

packages/cli-kit/src/public/node/vendor/otel-js/service/DefaultOtelService/DefaultMeterProvider.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {InstantaneousMetricReader} from '../../export/InstantaneousMetricReader.
22
import {OTLPMetricExporter, OTLPMetricExporterOptions} from '@opentelemetry/exporter-metrics-otlp-http'
33
import {Resource} from '@opentelemetry/resources'
44
import {AggregationTemporality, ConsoleMetricExporter, MeterProvider} from '@opentelemetry/sdk-metrics'
5-
import {SemanticResourceAttributes} from '@opentelemetry/semantic-conventions'
65

76
export type Environment = 'production' | 'staging' | 'local'
87

@@ -19,7 +18,7 @@ export class DefaultMeterProvider extends MeterProvider {
1918
constructor({serviceName, env, throttleLimit, useXhr, otelEndpoint}: DefaultMeterProviderOptions) {
2019
super({
2120
resource: new Resource({
22-
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
21+
['service.name']: serviceName,
2322
}),
2423
})
2524

pnpm-lock.yaml

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)