Fix lint: line length and unnecessary type assertion

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: ryancbahan

packages/app/src/cli/models/app/app.test-data.ts

@@ -137,7 +137,7 @@ export function testApp(app: Partial<AppInterface> = {}): AppInterface {
 }
 
 export function testAppLinked(app: Partial<AppInterface> = {}): AppLinkedInterface {
-  return testApp(app, 'current') as AppLinkedInterface
+  return testApp(app) as AppLinkedInterface
 }
 
 interface TestAppWithConfigOptions {

packages/app/src/cli/models/app/app.test.ts

@@ -1,5 +1,4 @@
 import {
-  AppConfiguration,
   AppSchema,
   CurrentAppConfiguration,
   getAppScopes,
@@ -574,14 +573,11 @@ describe('allExtensions', () => {
 
   test('keeps declarative webhook config when flag is enabled', async () => {
     const webhookExtensions = await testWebhookExtensions({complianceTopics: true})
-    const app = testApp(
-      {
-        configuration: CORRECT_CURRENT_APP_SCHEMA,
-        allExtensions: webhookExtensions,
-        remoteFlags: [],
-      },
-      'current',
-    )
+    const app = testApp({
+      configuration: CORRECT_CURRENT_APP_SCHEMA,
+      allExtensions: webhookExtensions,
+      remoteFlags: [],
+    })
 
     const webhookConfig = app.allExtensions.find((ext) => ext.handle === 'webhooks')!
       .configuration as unknown as WebhookTestConfig
@@ -596,33 +592,27 @@ describe('allExtensions', () => {
 
   test('includes configuration extensions when include_config_on_deploy is enabled', async () => {
     const configExtension = await testAppAccessConfigExtension()
-    const app = testApp(
-      {
-        configuration: CORRECT_CURRENT_APP_SCHEMA,
-        allExtensions: [configExtension],
-      },
-      'current',
-    )
+    const app = testApp({
+      configuration: CORRECT_CURRENT_APP_SCHEMA,
+      allExtensions: [configExtension],
+    })
 
     expect(app.allExtensions).toContain(configExtension)
   })
 
   test('includes configuration extensions by default when include_config_on_deploy is undefined', async () => {
     const configExtension = await testAppAccessConfigExtension()
-    const app = testApp(
-      {
-        configuration: {
-          ...CORRECT_CURRENT_APP_SCHEMA,
-          build: {
-            automatically_update_urls_on_dev: true,
-            dev_store_url: 'https://google.com',
-            include_config_on_deploy: undefined,
-          },
+    const app = testApp({
+      configuration: {
+        ...CORRECT_CURRENT_APP_SCHEMA,
+        build: {
+          automatically_update_urls_on_dev: true,
+          dev_store_url: 'https://google.com',
+          include_config_on_deploy: undefined,
         },
-        allExtensions: [configExtension],
       },
-      'current',
-    )
+      allExtensions: [configExtension],
+    })
 
     expect(app.allExtensions).toContain(configExtension)
   })
@@ -637,13 +627,10 @@ describe('allExtensions', () => {
       },
     }
     const configExtension = await testAppAccessConfigExtension()
-    const app = testApp(
-      {
-        configuration,
-        allExtensions: [configExtension],
-      },
-      'current',
-    )
+    const app = testApp({
+      configuration,
+      allExtensions: [configExtension],
+    })
 
     expect(app.allExtensions).toHaveLength(0)
   })

packages/app/src/cli/models/app/loader.ts

@@ -422,7 +422,8 @@ class AppLoader<TConfig extends CurrentAppConfiguration, TModuleSpec extends Ext
   }
 
   async loaded() {
-    const {configuration, directory, configPath, configurationLoadResultMetadata, configSchema} = this.loadedConfiguration
+    const {configuration, directory, configPath, configurationLoadResultMetadata, configSchema} =
+      this.loadedConfiguration
 
     await logMetadataFromAppLoadingProcess(configurationLoadResultMetadata)
 
@@ -958,12 +959,12 @@ async function loadAppConfigurationFromState<TModuleSpec extends ExtensionSpecif
   const appVersionedSchema = getAppVersionedSchema(specifications)
   const schemaForConfigurationFile = appVersionedSchema as SchemaForConfig<LoadedAppConfigFromConfigState>
 
-  const configuration = (await parseConfigurationFile(
+  const configuration = await parseConfigurationFile(
     schemaForConfigurationFile,
     configState.configurationPath,
     abort,
     file,
-  )) as LoadedAppConfigFromConfigState
+  )
   const allClientIdsByConfigName = await getAllLinkedConfigClientIds(configState.appDirectory, {
     [configState.configurationFileName]: configuration.client_id,
   })

packages/app/src/cli/services/app/config/use.test.ts

@@ -234,7 +234,7 @@ describe('use', () => {
   test('renders warning when warning message is specified', async () => {
     await inTemporaryDirectory(async (directory) => {
       // Given
-      const {configuration} = testApp({}, 'current')
+      const {configuration} = testApp({})
       const {schema: configSchema} = await buildVersionedAppSchema()
       vi.mocked(loadAppConfiguration).mockResolvedValue({
         directory,
@@ -265,7 +265,7 @@ describe('use', () => {
   test('does not render success when shouldRenderSuccess is false', async () => {
     await inTemporaryDirectory(async (directory) => {
       // Given
-      const {configuration} = testApp({}, 'current')
+      const {configuration} = testApp({})
       const {schema: configSchema} = await buildVersionedAppSchema()
       vi.mocked(loadAppConfiguration).mockResolvedValue({
         directory,

packages/app/src/cli/services/dev/urls.test.ts

@@ -336,7 +336,7 @@ describe('shouldOrPromptUpdateURLs', () => {
       currentURLs,
       appDirectory: '/path',
       apiKey: 'api-key',
-      localApp: testApp({configuration: {...DEFAULT_CONFIG, client_id: 'different'}}, 'current') as AppLinkedInterface,
+      localApp: testApp({configuration: {...DEFAULT_CONFIG, client_id: 'different'}}) as AppLinkedInterface,
       developerPlatformClient: testDeveloperPlatformClient(),
       newURLs: {
         applicationUrl: 'https://example.com/home',
@@ -356,7 +356,7 @@ describe('shouldOrPromptUpdateURLs', () => {
 
   test('updates the config file if current config client matches remote', async () => {
     // Given
-    const localApp = testApp({configuration: {...DEFAULT_CONFIG, client_id: 'api-key'}}, 'current')
+    const localApp = testApp({configuration: {...DEFAULT_CONFIG, client_id: 'api-key'}})
     const options = {
       currentURLs,
       appDirectory: '/path',