Last step

Author: gonzaloriestra

autoresearch.ideas.md

@@ -1,7 +1,7 @@
 # Autoresearch Ideas
 
 - **isolate: false** — drops collect from 415s to 99s but breaks 458 tests. If test isolation issues could be fixed (shared state, mock leaks), this would be a huge win. Would need systematic cleanup of global state in tests.
-- **Shard across multiple vitest instances** — run packages in parallel as separate processes to maximize CPU utilization. E.g., `vitest run --project=app & vitest run --project=cli-kit &` etc.
-- **Module caching / pre-bundling** — vitest deps optimization could help collect time by pre-bundling heavy deps
-- **Reduce heavy imports** — profile which modules take longest to collect. Large barrel exports or heavy dependencies slow down every test file that imports them.
-- **Split large test files** — if some test files are disproportionately slow, splitting them could improve parallelism
+- **Break up barrel exports** — `@shopify/cli-kit/node/ui` imports the entire UI library (React, Ink, all components). 30+ tests import this. Splitting into granular exports (e.g., `@shopify/cli-kit/node/ui/prompts`, `@shopify/cli-kit/node/ui/output`) could massively reduce collect time. Similarly `@shopify/cli-kit/node/fs` imports fs-extra, tempy, find-up, minimatch, fast-glob — 60+ test files pull all of this.
+- **Replace `inTemporaryDirectory` with in-memory fs** — Top slow tests (extension.test.ts, link.test.ts, app-context.test.ts, loader.test.ts) spend most time on temp dir I/O. Using memfs or mock fs could save seconds.
+- **Pre-compile test dependencies** — Use vitest's `deps.optimizer` to pre-bundle heavy node_modules (zod, fs-extra, ink, react) into faster ESM bundles.
+- **Split extension.test.ts** (7.5s, 24 tests) into 2-3 files to improve parallelism

autoresearch.jsonl

@@ -22,3 +22,9 @@
 {"run":21,"commit":"c60c268","metric":54.72,"metrics":{"collect_s":433.03,"tests_s":52.61,"transform_s":18.18,"setup_s":3.25,"prepare_s":23.74,"passed":3794,"files_passed":393},"status":"keep","description":"Reduce test delays: waitForInputsToBeReady 100→10ms, sendInputAndWait 100→10ms, fix tcp.test.ts sleep, use waitForContent for polling test — 54.72s (−19%), tests_s 52.6s (−28%)","timestamp":1773673656502,"segment":0}
 {"run":22,"commit":"be92061","metric":53.93,"metrics":{"collect_s":426.8,"tests_s":50.66,"transform_s":17.95,"setup_s":3.5,"prepare_s":24.11,"passed":3794,"files_passed":393},"status":"keep","description":"Reduce more setTimeout delays in app-event-watcher, file-watcher, ui, Tasks, AutocompletePrompt, http-reverse-proxy — 53.93s, tests_s 50.66s","timestamp":1773673894298,"segment":0}
 {"run":23,"commit":"be92061","metric":54.66,"metrics":{"collect_s":435.54,"tests_s":49.36,"transform_s":16.76,"setup_s":3.45,"prepare_s":24.24,"passed":3794,"files_passed":393},"status":"discard","description":"Remove setImmediate/clearImmediate from fakeTimers — 54.66s, no meaningful improvement","timestamp":1773674145847,"segment":0}
+{"run":24,"commit":"c6ada2e","metric":53.52,"metrics":{"collect_s":424.63,"tests_s":48.87,"transform_s":17.23,"setup_s":3.59,"prepare_s":24.34,"passed":3794,"files_passed":393},"status":"keep","description":"Reduce Dev.test.tsx sleep(0.1) to sleep(0.03) — 53.52s, tests_s 48.87s","timestamp":1773674249457,"segment":0}
+{"run":25,"commit":"c6ada2e","metric":54.04,"metrics":{"collect_s":428.43,"tests_s":49.08,"transform_s":16.54,"setup_s":3.63,"prepare_s":24.14,"passed":3793,"files_passed":392},"status":"discard","description":"Reduce ConcurrentOutput 50→10ms, TextAnimation 50→10ms — 54.04s, 1 flaky failure, within noise","timestamp":1773674468489,"segment":0}
+{"run":26,"commit":"c6ada2e","metric":54.66,"metrics":{"collect_s":436.83,"tests_s":50.33,"transform_s":16.77,"setup_s":2.86,"prepare_s":23.6,"passed":3794,"files_passed":393},"status":"discard","description":"ConcurrentOutput + TextAnimation timeout reductions — 54.66s, no improvement vs 53.52s","timestamp":1773674545663,"segment":0}
+{"run":27,"commit":"c6ada2e","metric":55.46,"metrics":{"collect_s":442.71,"tests_s":51.04,"transform_s":18.01,"setup_s":4.17,"prepare_s":24.54,"passed":3794,"files_passed":393},"status":"discard","description":"Use define for compile-time env constants — 55.46s, no improvement","timestamp":1773674670836,"segment":0}
+{"run":28,"commit":"c6ada2e","metric":0,"metrics":{"collect_s":0,"tests_s":0,"transform_s":0,"setup_s":0,"prepare_s":0,"passed":0,"files_passed":0},"status":"crash","description":"deps.optimizer.ssr with include list — crash: esbuild target doesn't support top-level await","timestamp":1773674765533,"segment":0}
+{"run":29,"commit":"c6ada2e","metric":53.93,"metrics":{"collect_s":426.24,"tests_s":51.09,"transform_s":17.63,"setup_s":3.36,"prepare_s":24.23,"passed":3744,"files_passed":385},"status":"discard","description":"deps.optimizer.ssr with esnext target — 50 test failures from import issues","timestamp":1773674837393,"segment":0}

configurations/vite.config.ts

@@ -28,6 +28,11 @@ export default function config(packagePath: string, {poolStrategy}: ConfigOption
   }
 
   return defineConfig({
+    define: {
+      'process.env.SHOPIFY_UNIT_TEST': '"1"',
+      'process.env.FORCE_HYPERLINK': '"0"',
+      'process.env.FORCE_COLOR': '"1"',
+    },
     resolve: {
       alias: aliases(packagePath) as AliasOptions,
     },

packages/cli-kit/src/private/node/ui/components/ConcurrentOutput.test.tsx

@@ -310,7 +310,7 @@ describe('ConcurrentOutput', () => {
       />,
     )
 
-    await new Promise((resolve) => setTimeout(resolve, 50))
+    await new Promise((resolve) => setTimeout(resolve, 10))
     expect(renderInstance.waitUntilExit().isRejected()).toBe(false)
   })
 
@@ -354,7 +354,7 @@ describe('ConcurrentOutput', () => {
       />,
     )
 
-    await new Promise((resolve) => setTimeout(resolve, 50))
+    await new Promise((resolve) => setTimeout(resolve, 10))
 
     expect(renderInstance.waitUntilExit().isFulfilled()).toBe(false)
   })

packages/cli-kit/src/private/node/ui/components/TextAnimation.test.tsx

@@ -69,7 +69,7 @@ describe('TextAnimation', () => {
     stdout.columns = 120
     resizeHandler()
 
-    await new Promise((resolve) => setTimeout(resolve, 50))
+    await new Promise((resolve) => setTimeout(resolve, 10))
 
     renderInstance.unmount()
   })

vite.config.ts

@@ -1,3 +1,16 @@
-import config from './configurations/vite.config'
+import {defineConfig} from 'vitest/config'
 
-export default config(__dirname)
+export default defineConfig({
+  test: {
+    projects: [
+      'packages/app/vite.config.ts',
+      'packages/cli/vite.config.ts',
+      'packages/cli-kit/vite.config.ts',
+      'packages/plugin-cloudflare/vite.config.ts',
+      'packages/plugin-did-you-mean/vite.config.ts',
+      'packages/theme/vite.config.ts',
+      'packages/ui-extensions-dev-console/vite.config.mts',
+      'packages/ui-extensions-server-kit/vite.config.mts',
+    ],
+  },
+})