Skip to content

Commit fe1f7ad

Browse files
Reduce more setTimeout delays in app-event-watcher, file-watcher, ui, Tasks, AutocompletePrompt, http-reverse-proxy — 53.93s, tests_s 50.66s\n\nResult: {"status":"keep","wall_clock_s":53.93,"collect_s":426.8,"tests_s":50.66,"transform_s":17.95,"setup_s":3.5,"prepare_s":24.11,"passed":3794,"files_passed":393}
1 parent b62337a commit fe1f7ad

8 files changed

Lines changed: 19 additions & 18 deletions

File tree

autoresearch.jsonl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@
1919
{"run":18,"commit":"f3f3069","metric":68.33,"metrics":{"collect_s":539.7,"tests_s":73.49,"transform_s":21.33,"setup_s":6.69,"prepare_s":28.33,"passed":3794,"files_passed":393},"status":"discard","description":"Remove coverage config — no improvement, coverage config is inert without --coverage flag","timestamp":1773672778674,"segment":0}
2020
{"run":19,"commit":"f3f3069","metric":66.11,"metrics":{"collect_s":521.27,"tests_s":71.55,"transform_s":16.87,"setup_s":5.4,"prepare_s":27.09,"passed":3790,"files_passed":391},"status":"discard","description":"unplugin-swc — transform 16.87s (−20%) but 4 test failures and no wall clock improvement","timestamp":1773672962547,"segment":0}
2121
{"run":20,"commit":"f3f3069","metric":68.27,"metrics":{"collect_s":540.74,"tests_s":71.54,"transform_s":19.85,"setup_s":3.65,"prepare_s":27.89,"passed":3794,"files_passed":393},"status":"discard","description":"Lazy ZodError check in setup — setup_s dropped to 3.65s but no wall clock improvement","timestamp":1773673284806,"segment":0}
22+
{"run":21,"commit":"c60c268","metric":54.72,"metrics":{"collect_s":433.03,"tests_s":52.61,"transform_s":18.18,"setup_s":3.25,"prepare_s":23.74,"passed":3794,"files_passed":393},"status":"keep","description":"Reduce test delays: waitForInputsToBeReady 100→10ms, sendInputAndWait 100→10ms, fix tcp.test.ts sleep, use waitForContent for polling test — 54.72s (−19%), tests_s 52.6s (−28%)","timestamp":1773673656502,"segment":0}

packages/app/src/cli/services/dev/app-events/app-event-watcher.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ describe('app-event-watcher', () => {
369369
await flushPromises()
370370

371371
// Wait for event processing
372-
await new Promise((resolve) => setTimeout(resolve, 100))
372+
await new Promise((resolve) => setTimeout(resolve, 10))
373373

374374
// Then
375375
expect(generateTypesSpy).toHaveBeenCalled()
@@ -405,7 +405,7 @@ describe('app-event-watcher', () => {
405405
await flushPromises()
406406

407407
// Wait for event processing
408-
await new Promise((resolve) => setTimeout(resolve, 100))
408+
await new Promise((resolve) => setTimeout(resolve, 10))
409409

410410
// Then - not called in watcher because it was already called during reloadApp
411411
expect(generateTypesSpy).not.toHaveBeenCalled()
@@ -441,7 +441,7 @@ describe('app-event-watcher', () => {
441441
await flushPromises()
442442

443443
// Wait for event processing
444-
await new Promise((resolve) => setTimeout(resolve, 100))
444+
await new Promise((resolve) => setTimeout(resolve, 10))
445445

446446
// Then - not called in watcher because it was already called during reloadApp
447447
expect(generateTypesSpy).not.toHaveBeenCalled()
@@ -474,7 +474,7 @@ describe('app-event-watcher', () => {
474474
await flushPromises()
475475

476476
// Wait for event processing
477-
await new Promise((resolve) => setTimeout(resolve, 100))
477+
await new Promise((resolve) => setTimeout(resolve, 10))
478478

479479
// Then - generateExtensionTypes should still be called when extensions are deleted
480480
// to clean up type definitions for the removed extension

packages/app/src/cli/services/dev/app-events/file-watcher.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -707,7 +707,7 @@ describe('file-watcher events', () => {
707707
}
708708

709709
// Wait for debounced events
710-
await new Promise((resolve) => setTimeout(resolve, 300))
710+
await new Promise((resolve) => setTimeout(resolve, 30))
711711

712712
// Test passes if we reach here without hanging
713713
clearTimeout(timeout)

packages/app/src/cli/services/dev/ui.test.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ describe('ui', () => {
189189
devSessionStatusManager,
190190
})
191191

192-
await new Promise((resolve) => setTimeout(resolve, 100))
192+
await new Promise((resolve) => setTimeout(resolve, 10))
193193

194194
expect(vi.mocked(Dev)).toHaveBeenCalled()
195195
expect(concurrentProcess.action).not.toHaveBeenCalled()
@@ -235,7 +235,7 @@ describe('ui', () => {
235235
devSessionStatusManager,
236236
})
237237

238-
await new Promise((resolve) => setTimeout(resolve, 100))
238+
await new Promise((resolve) => setTimeout(resolve, 10))
239239

240240
expect(vi.mocked(DevSessionUI)).toHaveBeenCalledWith(
241241
expect.objectContaining({
@@ -286,7 +286,7 @@ describe('ui', () => {
286286
devSessionStatusManager,
287287
})
288288

289-
await new Promise((resolve) => setTimeout(resolve, 100))
289+
await new Promise((resolve) => setTimeout(resolve, 10))
290290

291291
// Get the onAbort callback that was passed to DevSessionUI
292292
const onAbort = vi.mocked(DevSessionUI).mock.calls[0]?.[0]?.onAbort

packages/app/src/cli/utilities/app/http-reverse-proxy.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe.sequential.each(each)('http-reverse-proxy for %s', (protocol) => {
5959
// eslint-disable-next-line no-catch-all/no-catch-all
6060
} catch (error) {
6161
// If the assertion fails, wait a bit and try again
62-
await new Promise((resolve) => setTimeout(resolve, 100))
62+
await new Promise((resolve) => setTimeout(resolve, 10))
6363
await expect(fetch(`${protocol}://localhost:${ports.proxyPort}/path1`, {agent})).rejects.toThrow()
6464
}
6565
})

packages/cli-kit/src/private/node/ui/components/AutocompletePrompt.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ describe('AutocompletePrompt', async () => {
348348
await waitForInputsToBeReady()
349349
await sendInputAndWaitForContent(renderInstance, 'Loading...', 'a')
350350
// prompt doesn't change when enter is pressed
351-
await new Promise((resolve) => setTimeout(resolve, 100))
351+
await new Promise((resolve) => setTimeout(resolve, 10))
352352
await sendInputAndWait(renderInstance, 10, ENTER)
353353

354354
expect(renderInstance.lastFrame()).toMatchInlineSnapshot(`

packages/cli-kit/src/private/node/ui/components/ConcurrentOutput.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ describe('ConcurrentOutput', () => {
310310
/>,
311311
)
312312

313-
await new Promise((resolve) => setTimeout(resolve, 500))
313+
await new Promise((resolve) => setTimeout(resolve, 50))
314314
expect(renderInstance.waitUntilExit().isRejected()).toBe(false)
315315
})
316316

@@ -354,7 +354,7 @@ describe('ConcurrentOutput', () => {
354354
/>,
355355
)
356356

357-
await new Promise((resolve) => setTimeout(resolve, 500))
357+
await new Promise((resolve) => setTimeout(resolve, 50))
358358

359359
expect(renderInstance.waitUntilExit().isFulfilled()).toBe(false)
360360
})

packages/cli-kit/src/private/node/ui/components/Tasks.test.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('Tasks', () => {
7777
test('it supports subtasks', async () => {
7878
// Given
7979
const firstSubtaskFunction = vi.fn(async () => {
80-
await new Promise((resolve) => setTimeout(resolve, 100))
80+
await new Promise((resolve) => setTimeout(resolve, 10))
8181
})
8282

8383
const secondSubtaskFunction = vi.fn(async () => {})
@@ -115,11 +115,11 @@ describe('Tasks', () => {
115115
test('supports skipping', async () => {
116116
// Given
117117
const firstTaskFunction = vi.fn(async () => {
118-
await new Promise((resolve) => setTimeout(resolve, 100))
118+
await new Promise((resolve) => setTimeout(resolve, 10))
119119
})
120120

121121
const secondTaskFunction = vi.fn(async () => {
122-
await new Promise((resolve) => setTimeout(resolve, 100))
122+
await new Promise((resolve) => setTimeout(resolve, 10))
123123
})
124124

125125
const firstTask = {
@@ -145,11 +145,11 @@ describe('Tasks', () => {
145145
test('supports skipping a subtask', async () => {
146146
// Given
147147
const firstSubTaskFunction = vi.fn(async () => {
148-
await new Promise((resolve) => setTimeout(resolve, 100))
148+
await new Promise((resolve) => setTimeout(resolve, 10))
149149
})
150150

151151
const secondSubTaskFunction = vi.fn(async () => {
152-
await new Promise((resolve) => setTimeout(resolve, 100))
152+
await new Promise((resolve) => setTimeout(resolve, 10))
153153
})
154154

155155
const firstTask = {
@@ -416,5 +416,5 @@ describe('Tasks', () => {
416416
})
417417

418418
async function taskHasRendered() {
419-
await new Promise((resolve) => setTimeout(resolve, 100))
419+
await new Promise((resolve) => setTimeout(resolve, 10))
420420
}

0 commit comments

Comments
 (0)