Fix E2E fixture sidekick summary#7658
Merged
Merged
Conversation
github-actions
Bot
added
the
no-changelog
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the fully populated E2E app TOML fixture so tests that overwrite generated extension-only app configs retain the Sidekick summary required by sidekick-eligible extensions.
Changes:
- Adds a
[sidekick]section to the valid app fixture. - Adds
extensions_summarywith a descriptive placeholder summary used by E2E config replacement flows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ryancbahan
approved these changes
May 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[sidekick].extensions_summaryto the E2E fully-populated app TOML fixtureshopify.app.tomlaligned with the extension-only template, which already includes a Sidekick summaryWhy
Recent E2E failures were not caused by the app-dev assertions themselves. Several tests create an app from the extension-only template and then replace its generated
shopify.app.tomlwithpackages/e2e/data/valid-app/shopify.app.toml. That replacement dropped the Sidekick summary required when sidekick-eligible extensions are present, so deploy/dev failed before reachingReady, watching for changes in your app.Validation
pnpm --filter e2e exec playwright test --listpackages/e2e/data/valid-app/shopify.app.tomlwith@iarna/tomland verifiedsidekick.extensions_summary