Fix fetch-depth in release workflows#6709
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3492 tests passing in 1408 suites. Report generated by 🧪jest coverage report action from 488f5cc |
katiebauchman
left a comment
There was a problem hiding this comment.
LGTM - correctly changes fetch-depth to retrieve full git history.
Quick question (maybe I don't understand fully): is fetching full history expected to resolve the 403 push error, or are there additional changes needed?
|
Which 403 push error? 🤔 I expect it to fix this error and hopefully the full release process: |
|
Oh ok! I just saw in the original message the line that said |
|
Ahh, sorry, now I see it. Yeah, I guess it's the same error, let's see! |
WHY are these changes introduced?
Continuation of #6707
The release workflow is not working yet: https://github.com/Shopify/cli/actions/runs/20134579239/job/57784328999
WHAT is this pull request doing?
Apparently, when using OIDC authentication, NPM enforces provenance generation (which was previously optional/ignored with tokens), and provenance requires full git history to work correctly.
So I'm updating the Git checkout step to retrieve the full history with a fetch-depth of 0
How to test your changes?
Merge and check
Measuring impact
How do we know this change was effective? Please choose one:
Checklist