Skip to content

E2E: .env.example cleanup after test isolation#7383

Merged
phyllis-sy-wu merged 1 commit intomainfrom
psyw-0423-E2E-env-cleanup-after-test-isolation
Apr 23, 2026
Merged

E2E: .env.example cleanup after test isolation#7383
phyllis-sy-wu merged 1 commit intomainfrom
psyw-0423-E2E-env-cleanup-after-test-isolation

Conversation

@phyllis-sy-wu
Copy link
Copy Markdown
Contributor

@phyllis-sy-wu phyllis-sy-wu commented Apr 23, 2026

WHY are these changes introduced?

The E2E_STORE_FQDN environment variable is no longer required for e2e tests and should be removed from the e2e configuration. Additionally, the E2E_ORG_ID variable was missing its CI secret annotation comment.

WHAT is this pull request doing?

Removes the E2E_STORE_FQDN environment variable from the e2e .env.example file and adds the missing # CI secret: E2E_ORG_ID comment to the E2E_ORG_ID variable, bringing it in line with the documentation style used for other secrets.

How to test your changes?

Verify that e2e tests run successfully without the E2E_STORE_FQDN variable set in the environment.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@phyllis-sy-wu phyllis-sy-wu marked this pull request as ready for review April 23, 2026 12:20
@phyllis-sy-wu phyllis-sy-wu requested a review from a team as a code owner April 23, 2026 12:20
Copilot AI review requested due to automatic review settings April 23, 2026 12:20
@phyllis-sy-wu phyllis-sy-wu linked an issue Apr 23, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the E2E environment example file to reflect current test requirements and keep CI-secret annotations consistent with the repo’s .env.example documentation style.

Changes:

  • Removes the no-longer-needed E2E_STORE_FQDN entry from the E2E .env.example.
  • Adds the missing # CI secret: E2E_ORG_ID annotation above E2E_ORG_ID.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@amcaplan amcaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so I assume this is fine 👍

@phyllis-sy-wu phyllis-sy-wu added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 243750a Apr 23, 2026
52 of 53 checks passed
@phyllis-sy-wu phyllis-sy-wu deleted the psyw-0423-E2E-env-cleanup-after-test-isolation branch April 23, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E: Cleanup unused codes

3 participants