Skip to content

[Performance] Remove redundant JSON cycle in analytics #7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gonzaloriestra wants to merge 1 commit into from
Closed

[Performance] Remove redundant JSON cycle in analytics #7654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/cli-kit/src/public/node/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ async function buildPayload({config, errorMessage, exitMode}: ReportAnalyticsEve
const wallClockElapsed = currentTime - startTime
const totalTimeWithoutSubtimers = wallClockElapsed - totalTimeFromSubtimers

let payload = {
const payload = {
public: {
command: startCommand,
time_start: startTime,
Expand Down Expand Up @@ -192,9 +192,6 @@ async function buildPayload({config, errorMessage, exitMode}: ReportAnalyticsEve
}
})

// strip undefined fields -- they make up the majority of payloads due to wide metadata structure.
payload = JSON.parse(JSON.stringify(payload))

return sanitizePayload(payload)
}

Expand Down
Loading