Skip to content

Preserve generated TOML fields in E2E fixtures#7659

Merged
dmerand merged 1 commit into
mainfrom
donald/e2e-fixture-overlay
May 28, 2026
Merged

Preserve generated TOML fields in E2E fixtures#7659
dmerand merged 1 commit into
mainfrom
donald/e2e-fixture-overlay

Conversation

@dmerand

@dmerand dmerand commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • merge the fully-populated E2E TOML fixture into the generated template config instead of replacing it wholesale
  • preserve template-owned fields when the fixture only needs to override/add app config values
  • add lightweight fixture coverage for preserving generated fields and for the Sidekick summary fixture path

Why

PR #7658 fixes the immediate missing [sidekick].extensions_summary field. This stacked follow-up removes the underlying footgun: several E2E tests create an app from the extension-only template, then overwrite the generated shopify.app.toml with packages/e2e/data/valid-app/shopify.app.toml. Future template-required fields could regress the same way.

By treating the fixture as an overlay, tests keep template-provided config unless the fixture explicitly overrides it.

Validation

  • pnpm --filter e2e exec playwright test tests/fixture-toml.spec.ts --reporter=list
  • pnpm exec tsc --noEmit --project packages/e2e/tsconfig.json
  • pnpm --filter e2e lint

Note: pnpm --filter e2e type-check was not useful in this ad-hoc worktree because its Nx dependency builds failed to resolve workspace package dependencies from the symlinked node_modules setup; the direct e2e TypeScript check above passed.

dmerand commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 28, 2026
@dmerand dmerand marked this pull request as ready for review May 28, 2026 15:43
@dmerand dmerand requested a review from a team as a code owner May 28, 2026 15:43
@dmerand dmerand marked this pull request as draft May 28, 2026 15:44
@dmerand dmerand force-pushed the donald/e2e-fixture-overlay branch from 172baa1 to b432122 Compare May 28, 2026 16:45
@dmerand dmerand marked this pull request as ready for review May 28, 2026 16:56
@dmerand dmerand force-pushed the donald/e2e-fixture-overlay branch from b432122 to 757a1f9 Compare May 28, 2026 17:37
@dmerand dmerand force-pushed the donald/e2e-fixture-overlay branch from 757a1f9 to 7a41b90 Compare May 28, 2026 17:59
Base automatically changed from donald/fix-e2e-sidekick-summary to main May 28, 2026 20:28
@dmerand dmerand added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit 2091634 May 28, 2026
25 of 26 checks passed
@dmerand dmerand deleted the donald/e2e-fixture-overlay branch May 28, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants