Preserve generated TOML fields in E2E fixtures#7659
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ryancbahan
approved these changes
May 28, 2026
172baa1 to
b432122
Compare
b432122 to
757a1f9
Compare
757a1f9 to
7a41b90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
PR #7658 fixes the immediate missing
[sidekick].extensions_summaryfield. This stacked follow-up removes the underlying footgun: several E2E tests create an app from the extension-only template, then overwrite the generatedshopify.app.tomlwithpackages/e2e/data/valid-app/shopify.app.toml. Future template-required fields could regress the same way.By treating the fixture as an overlay, tests keep template-provided config unless the fixture explicitly overrides it.
Validation
pnpm --filter e2e exec playwright test tests/fixture-toml.spec.ts --reporter=listpnpm exec tsc --noEmit --project packages/e2e/tsconfig.jsonpnpm --filter e2e lintNote:
pnpm --filter e2e type-checkwas not useful in this ad-hoc worktree because its Nx dependency builds failed to resolve workspace package dependencies from the symlinked node_modules setup; the direct e2e TypeScript check above passed.