Skip to content

Commit e02948e

Browse files
committed
fix(ci): address review comments — tighten auth guards, fix review event handling, align adb docs
- Tighten author_association to OWNER/MEMBER/COLLABORATOR (was != NONE) - Handle pull_request_review events correctly (use review.author_association) - Align adb exceptions between agent-device and fix-github-issue skills - claude-code-action@beta not pinned (moving tag, need latest beta features)
1 parent 526ac7d commit e02948e

4 files changed

Lines changed: 16 additions & 4 deletions

File tree

.claude/skills/agent-device/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ description: Interact with iOS simulator or Android emulator/device using snapsh
99

1010
**Banned tools/commands** (never use these for device interaction, even if they seem easier):
1111

12-
- `adb` / `adb shell` — no `input tap`, `input swipe`, `input text`, `screencap`, `am start`, etc. (exception: `adb shell screenrecord` + `adb pull` for Android recording — see "Android Recording Workaround")
12+
- `adb` for UI interaction — no `input tap`, `input swipe`, `input text`, `screencap`, etc. Allowed exceptions: `adb devices`, `adb wait-for-device`, `adb install`, `adb reverse`, `adb shell getprop`, `adb shell am`, `adb shell pm`, `adb shell screenrecord` + `adb pull` (see "Android Recording Workaround"), `adb shell kill`/`adb shell pidof` (for stopping screenrecord)
1313
- Mobile MCP tools — no `mobile_click_on_screen_at_coordinates`, `mobile_take_screenshot`, `mobile_list_elements_on_screen`, `mobile_swipe_on_screen`, `mobile_type_keys`, `mobile_press_button`, `mobile_long_press_on_screen_at_coordinates`, or any other `mobile_*` tool
1414
- `xcrun simctl` — no `simctl io screenshot`, `simctl launch`, `simctl openurl`, etc. (exception: `simctl list devices` to check boot state is OK)
1515
- `osascript` / AppleScript for simulator control

.github/workflows/agent-android-bot.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,11 @@ jobs:
4646
(
4747
contains(github.event.comment.body || github.event.review.body, '@android-agent') &&
4848
!contains(github.event.comment.body || github.event.review.body, '/fix') &&
49-
github.event.comment.author_association != 'NONE'
49+
(
50+
(github.event.comment.author_association || github.event.review.author_association) == 'OWNER' ||
51+
(github.event.comment.author_association || github.event.review.author_association) == 'MEMBER' ||
52+
(github.event.comment.author_association || github.event.review.author_association) == 'COLLABORATOR'
53+
)
5054
)
5155
steps:
5256
- name: Checkout

.github/workflows/agent-bot.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,11 @@ jobs:
4343
(
4444
contains(github.event.comment.body || github.event.review.body, '@agent') &&
4545
!contains(github.event.comment.body || github.event.review.body, '/fix') &&
46-
github.event.comment.author_association != 'NONE'
46+
(
47+
(github.event.comment.author_association || github.event.review.author_association) == 'OWNER' ||
48+
(github.event.comment.author_association || github.event.review.author_association) == 'MEMBER' ||
49+
(github.event.comment.author_association || github.event.review.author_association) == 'COLLABORATOR'
50+
)
4751
)
4852
steps:
4953
- name: Checkout

.github/workflows/agent-fix.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ jobs:
3737
github.event.action == 'created' &&
3838
contains(github.event.comment.body, '/fix') &&
3939
!github.event.issue.pull_request &&
40-
github.event.comment.author_association != 'NONE'
40+
(
41+
github.event.comment.author_association == 'OWNER' ||
42+
github.event.comment.author_association == 'MEMBER' ||
43+
github.event.comment.author_association == 'COLLABORATOR'
44+
)
4145
)
4246
timeout-minutes: 60
4347
steps:

0 commit comments

Comments
 (0)