Skip to content

Commit 2c66015

Browse files
committed
chore: remove temporary compile_binary diagnostics
The go env / vendor/modules.txt diagnostic lines added in the previous commit have served their purpose. Retain the Open3.capture2e change so that go build errors remain visible in the test failure message.
1 parent 41708ff commit 2c66015

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

test/helpers/ghostferry_helper.rb

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -143,17 +143,6 @@ def compile_binary
143143

144144
@logger.debug("compiling test binary to #{@compiled_binary_path}")
145145

146-
# Diagnostics: dump Go environment before building so that CI failures
147-
# show the actual cause rather than the generic "could not compile" message.
148-
# Captures GOMOD / GOWORK / GOFLAGS to detect unexpected workspace or
149-
# vendor-mode activation, and checks for a repo-level vendor/modules.txt.
150-
go_env, _ = Open3.capture2e("go", "env", "GOMOD", "GOWORK", "GOFLAGS")
151-
repo_root = File.expand_path("../..", __dir__)
152-
vendor_txt = File.join(repo_root, "vendor", "modules.txt")
153-
@logger.debug("[compile_binary] go env: #{go_env.strip}")
154-
@logger.debug("[compile_binary] repo_root: #{repo_root}")
155-
@logger.debug("[compile_binary] vendor/modules.txt present: #{File.exist?(vendor_txt)}")
156-
157146
# Use capture2e so that go build stderr is included in the raised error
158147
# message rather than being swallowed by the test runner.
159148
output, status = Open3.capture2e(

0 commit comments

Comments
 (0)