Merge pull request #430 from Shopify/get-rid-of-vendored-packages

Get rid of vendored packages

Author: driv3r

.gitattributes

@@ -6,6 +6,14 @@ on:
       - main
   pull_request:
 
+# Prevent Go from auto-activating vendor mode when a stale vendor/ directory
+# exists in the workspace. Actions/checkout does not always remove previously
+# tracked files that were deleted in a later commit, so a checkout of a commit
+# that removed vendor/ may still find the directory on disk, causing
+# "inconsistent vendoring" build failures.
+env:
+  GOFLAGS: "-mod=mod"
+
 jobs:
   gh-285:
     strategy:

.github/workflows/tests.yml

@@ -9,6 +9,10 @@ All notable changes to this project will be documented in this file.
 - Align default zerolog log level with logrus (info vs trace)
 - Introduce slog handler wrapper around our Logger interface and use it with BinlogStreamer
 
+### Removed
+
+- Vendored packages are removed in favour of normal `go mod`
+
 ## [1.3.0 - 2026-04-08]
 
 ### Changed

CHANGELOG.md

@@ -142,13 +142,16 @@ def compile_binary
       return if File.exist?(@compiled_binary_path)
 
       @logger.debug("compiling test binary to #{@compiled_binary_path}")
-      rc = system(
+
+      # Use capture2e so that go build stderr is included in the raised error
+      # message rather than being swallowed by the test runner.
+      output, status = Open3.capture2e(
         "go", "build",
         "-o", @compiled_binary_path,
         @main_path
       )
 
-      raise "could not compile ghostferry" unless rc
+      raise "could not compile ghostferry:\n#{output}" unless status.success?
     end
 
     def start_server