Check for ascii_only? before re-encoding strings

Author: rmosolgo

lib/graphql/schema/argument.rb

@@ -54,15 +54,7 @@ def from_resolver?
       # @param replace_null_with_default [Boolean] if `true`, incoming values of `null` will be replaced with the configured `default_value`
       def initialize(arg_name = nil, type_expr = nil, desc = nil, required: true, type: nil, name: nil, loads: nil, description: nil, ast_node: nil, default_value: NO_DEFAULT, as: nil, from_resolver: false, camelize: true, prepare: nil, owner:, validates: nil, directives: nil, deprecation_reason: nil, replace_null_with_default: false, &definition_block)
         arg_name ||= name
-        name_s = camelize ? Member::BuildType.camelize(arg_name.to_s) : arg_name.to_s
-        if name_s.encoding != Encoding::UTF_8
-          if name_s.frozen?
-            name_s = name_s.encode(Encoding::UTF_8)
-          else
-            name_s.encode!(Encoding::UTF_8)
-          end
-        end
-        @name = -name_s
+        @name = -(camelize ? Member::BuildType.camelize(arg_name.to_s) : arg_name.to_s)
         @type_expr = type_expr || type
         @description = desc || description
         @null = required != true

lib/graphql/schema/field.rb

@@ -228,15 +228,7 @@ def initialize(type: nil, name: nil, owner: nil, null: nil, description: :not_gi
           end
         end
         @original_name = name
-        name_s = name.to_s
-        if name_s.encoding != Encoding::UTF_8
-          if name_s.frozen?
-            name_s = name_s.encode(Encoding::UTF_8)
-          else
-            name_s.encode!(Encoding::UTF_8)
-          end
-        end
-        name_s = -name_s
+        name_s = -name.to_s
 
         @underscored_name = -Member::BuildType.underscore(name_s)
         @name = -(camelize ? Member::BuildType.camelize(name_s) : name_s)

lib/graphql/schema/member/base_dsl_methods.rb

@@ -103,7 +103,7 @@ def default_graphql_name
           @default_graphql_name ||= begin
             raise GraphQL::RequiredImplementationMissingError, 'Anonymous class should declare a `graphql_name`' if name.nil?
 
-            -name.split("::").last.sub(/Type\Z/, "").encode(Encoding::UTF_8)
+            -name.split("::").last.sub(/Type\Z/, "")
           end
         end
 

lib/graphql/types/string.rb

@@ -7,7 +7,7 @@ class String < GraphQL::Schema::Scalar
 
       def self.coerce_result(value, ctx)
         str = value.to_s
-        if str.encoding == Encoding::UTF_8
+        if str.ascii_only? || str.encoding == Encoding::UTF_8
           str
         elsif str.frozen?
           str.encode(Encoding::UTF_8)