Make Shopify-shaped benchmarks portable

Author: tobi

README.md

@@ -570,8 +570,8 @@ The benchmark suite currently includes 10 realistic templates:
 | `bench_storefront_cart_page` | Standard-Liquid cart totals, discounts, and line items |
 | `bench_storefront_order_email` | Standard-Liquid transactional order email |
 | `bench_storefront_cms_page` | Standard-Liquid content-management page |
-| `shopify_theme_full_page` | Full Shopify Dream theme layout using Shopify filters |
-| `shopify_theme_product_page` | Shopify Dream product page using Shopify filters |
+| `shopify_theme_full_page` | Shopify-shaped Dream theme layout using portable Liquid |
+| `shopify_theme_product_page` | Shopify-shaped Dream product page using portable Liquid |
 
 Selecting these specs through `liquid-spec run ADAPTER -s benchmarks` checks correctness
 without collecting timings; use `liquid-spec bench` for performance measurements.

docs/implementers/shopify-theme-filters.md

@@ -7,18 +7,20 @@ optional: true
 
 # Shopify Theme Filters
 
-The theme benchmark templates (`specs/benchmarks/theme_*.yml`) use Shopify-specific filters and
-tags that are not part of core Liquid. This document provides a complete reference implementation
-in Ruby that can serve as pseudocode for implementing these in any language.
+The default benchmark templates are intentionally portable and do not require Shopify
+filters. Optional Shopify theme suites still exercise filters and tags that are not part
+of core Liquid. This document provides a reference implementation in Ruby that can serve
+as pseudocode when an adapter deliberately targets that Shopify-specific surface.
 
-These are required when your adapter declares `features: [:shopify_filters]`.
+These helpers apply to specs tagged `shopify_filters`; they are not required for
+`liquid-spec bench`.
 
 ---
 
 ## Complete Reference Implementation
 
-The following Ruby module implements all required filters. Register it with your Liquid
-environment to pass the `shopify_helpers.yml` specs and run the theme benchmarks.
+The following Ruby module illustrates the filter behavior. Register equivalent helpers
+only when running Shopify-specific suites.
 
 ```ruby
 # Reference implementation of Shopify theme filters.

specs/benchmarks/storefront.yml

@@ -2,7 +2,7 @@
 _metadata:
   hint: |
     Full storefront benchmark using ONLY standard Liquid features (no Shopify-specific
-    filters/tags). This is the non-Shopify equivalent of the theme_* benchmarks.
+    filters/tags). It complements the smaller Shopify-shaped portable theme benchmarks.
     Exercises: render, include (static + dynamic), for loops, nested for loops,
     forloop object, if/elsif/else/unless, case/when, assign, capture, increment,
     decrement, cycle, tablerow, comment, raw, liquid tag, echo, whitespace control,

specs/benchmarks/theme_layout.yml

@@ -1,9 +1,8 @@
 ---
 _metadata:
-  hint: Real Shopify Dream theme benchmark — requires shopify_filters feature
-  doc: implementers/shopify-theme-filters.md
-  features:
-    - shopify_filters
+  hint: |
+    Shopify-shaped Dream theme layout benchmark expressed with portable Liquid.
+    Asset paths use standard string filters, so no Shopify runtime is required.
   data_files:
     - _data/theme_database.yml
 specs:
@@ -19,7 +18,7 @@ specs:
       <title>{{ page_title }}{% if page_title %} - {% endif %}{{ shop.name }}</title>
 
       <link rel="canonical" href="{{ canonical_url }}">
-      <link rel="stylesheet" href="{{ 'theme.css' | asset_url }}">
+      <link rel="stylesheet" href="{{ 'theme.css' | prepend: '/assets/' }}">
 
       {{ content_for_header }}
     </head>
@@ -108,7 +107,7 @@ specs:
         </footer>
       </div>
 
-      <script src="{{ 'theme.js' | asset_url }}" defer></script>
+      <script src="{{ 'theme.js' | prepend: '/assets/' }}" defer></script>
     </body>
     </html>
   environment:

specs/benchmarks/theme_product.yml

@@ -1,9 +1,8 @@
 ---
 _metadata:
-  hint: Real Shopify Dream theme benchmark — requires shopify_filters feature
-  doc: implementers/shopify-theme-filters.md
-  features:
-    - shopify_filters
+  hint: |
+    Shopify-shaped Dream product benchmark expressed with portable Liquid.
+    CDN paths, cents conversion, and tag slugs use standard filters only.
   data_files:
     - _data/theme_database.yml
 specs:
@@ -26,12 +25,12 @@ specs:
           <div class="product__media">
             <div class="product__gallery">
               <div class="product__main-image">
-                <img src="{{ product.featured_image | product_img_url: 'large' }}" alt="{{ product.title | escape }}">
+                <img src="{{ product.featured_image | prepend: '/cdn/' }}" alt="{{ product.title | escape }}">
               </div>
               <div class="product__thumbnails">
                 {% for image in product.images %}
                   <button class="product__thumbnail-item" data-image-index="{{ forloop.index }}">
-                    <img src="{{ image | product_img_url: 'small' }}" alt="{{ product.title | escape }} - {{ forloop.index }}">
+                    <img src="{{ image | prepend: '/cdn/' }}" alt="{{ product.title | escape }} - {{ forloop.index }}">
                   </button>
                 {% endfor %}
               </div>
@@ -43,11 +42,11 @@ specs:
 
             <div class="product__pricing">
               {% if product.compare_at_price > product.price %}
-                <span class="product__price product__price--sale">{{ product.price | money }}</span>
-                <span class="product__price product__price--compare">{{ product.compare_at_price | money }}</span>
+                <span class="product__price product__price--sale">${{ product.price | divided_by: 100.0 }}</span>
+                <span class="product__price product__price--compare">${{ product.compare_at_price | divided_by: 100.0 }}</span>
                 <span class="product__badge">Sale</span>
               {% else %}
-                <span class="product__price">{{ product.price | money }}</span>
+                <span class="product__price">${{ product.price | divided_by: 100.0 }}</span>
               {% endif %}
             </div>
 
@@ -63,7 +62,7 @@ specs:
                   <select name="id" id="ProductSelect" class="product-form__select">
                     {% for variant in product.variants %}
                       <option value="{{ variant.id }}" {% if variant.available == false %}disabled{% endif %}>
-                        {{ variant.title }} - {{ variant.price | money }}{% if variant.available == false %} - Sold out{% endif %}
+                        {{ variant.title }} - ${{ variant.price | divided_by: 100.0 }}{% if variant.available == false %} - Sold out{% endif %}
                       </option>
                     {% endfor %}
                   </select>
@@ -100,7 +99,7 @@ specs:
               <ul class="tag-list">
                 {% for tag in product.tags %}
                   <li class="tag-list__item">
-                    <a href="/collections/all/{{ tag | handle }}" class="tag">{{ tag }}</a>
+                    <a href="/collections/all/{{ tag | downcase | replace: ' ', '-' | url_encode }}" class="tag">{{ tag }}</a>
                   </li>
                 {% endfor %}
               </ul>
@@ -177,16 +176,16 @@ specs:
       <div class="product-card">
         <a href="{{ product.url }}" class="product-card__link">
           <div class="product-card__image">
-            <img src="{{ product.featured_image | product_img_url: 'medium' }}" alt="{{ product.title | escape }}">
+            <img src="{{ product.featured_image | prepend: '/cdn/' }}" alt="{{ product.title | escape }}">
           </div>
           <div class="product-card__info">
             <h3 class="product-card__title">{{ product.title }}</h3>
             <div class="product-card__price">
               {% if product.compare_at_price > product.price %}
-                <span class="product-card__price--sale">{{ product.price | money }}</span>
-                <span class="product-card__price--compare">{{ product.compare_at_price | money }}</span>
+                <span class="product-card__price--sale">${{ product.price | divided_by: 100.0 }}</span>
+                <span class="product-card__price--compare">${{ product.compare_at_price | divided_by: 100.0 }}</span>
               {% else %}
-                <span class="product-card__price--regular">{{ product.price | money }}</span>
+                <span class="product-card__price--regular">${{ product.price | divided_by: 100.0 }}</span>
               {% endif %}
             </div>
           </div>

test/benchmark_test.rb

@@ -3,13 +3,31 @@
 require_relative "test_helper"
 require "liquid/spec/cli/benchmark"
 require "liquid/spec/cli/fork_benchmark"
+require "liquid/spec/suite"
 
 class BenchmarkTest < Minitest::Test
   Benchmark = Liquid::Spec::CLI::Benchmark
   ForkBenchmark = Liquid::Spec::CLI::ForkBenchmark
 
   FakeSpec = Struct.new(:name)
 
+  def test_shopify_shaped_benchmarks_use_only_portable_liquid
+    suite = Liquid::Spec::Suite.find(:benchmarks)
+    specs = Liquid::Spec::SpecLoader.load_suite(suite).select do |spec|
+      %w[shopify_theme_full_page shopify_theme_product_page].include?(spec.name)
+    end
+
+    assert_equal 2, specs.size
+    specs.each do |spec|
+      source = ([spec.template] + spec.raw_filesystem.values).join("\n")
+      assert_empty spec.features.grep(/shopify/), "#{spec.name} should not require Shopify features"
+      refute_match(/\|\s*(?:asset_url|product_img_url|money|handle)\b/, source,
+        "#{spec.name} should not use Shopify-only filters")
+      refute_match(/\{%[-]?\s*(?:schema|style|section|paginate|form)\b/, source,
+        "#{spec.name} should not use Shopify-only tags")
+    end
+  end
+
   def test_compact_preserves_sub_microsecond_precision_and_integer_ns
     value = {
       mean: 0.000_000_432_123,