Congrats addendum with dynamic skipped features, strict2 clearability

Runner:
- "Complexity level cleared: NN of MM" — level is the highest complexity
  present below the first failing level (real ramp level, not interpolated);
  MM is the max complexity in the run.
- Congrats addendum at 100% (0 failures, level = max): 3 paths forward.
  The optional-feature list is dynamic — built from features that ACTUALLY
  had specs skipped this run (tracked in filter_by_missing), filtered through
  Features::FEATURE_DOCS to :optional, excluding :unnecessary Ruby-interop
  ones. Adapters that skipped no optional specs get the "push beyond the
  suite" suggestion instead.
- Path shortening (<gem>/.../basename:line) and skipped count retained.

strict2 clearability:
- Gate the 7 "NEW STRICT2 CONTRACT" blank-body strict2 specs in
  blank_body_error_handling.yml behind a new strict2_blank_body_errors
  feature. liquid-ruby 5.13 renders "" for these (suppresses blank-body
  errors even in strict2), so they were unimplementable and blocked
  clearing for any adapter implementing strict2 + inline_errors.
- Register strict2_blank_body_errors in Features::FEATURE_DOCS as
  :unnecessary (aspirational, not yet implemented by liquid-ruby).
- Add to reference adapter (examples/liquid_ruby.rb) and JSON-RPC template
  missing_features so they opt out by default. Documented in CLAUDE.md.

Author: tobi

CLAUDE.md

@@ -536,6 +536,7 @@ Feature selection is denylist-based. Leave `missing_features` empty to try every
 - `:lax_parsing` - Adapter does not support `error_mode: :lax`
 - `:ruby_types` / `:ruby_drops` / `:binary_data` - Adapter cannot consume Ruby-specific values from specs
 - `:template_factory` - Adapter cannot support template factory/artifact callbacks
+- `:strict2_blank_body_errors` - Aspirational "NEW STRICT2 CONTRACT" (strict2 surfaces inline errors even for blank block bodies); liquid-ruby 5.13 does not implement this, so opt out until your adapter deliberately adopts it
 
 **Shopify-specific features:**
 - `:shopify_tags` - Shopify-specific tags (schema, style, section)

examples/liquid_ruby.rb

@@ -20,7 +20,7 @@
 end
 
 LiquidSpec.configure do |config|
-  config.missing_features = [:self_environment_shadowing, :drop_class_output, :shopify_filters, :shopify_includes, :shopify_blank, :shopify_error_handling, :shopify_error_format, :shopify_string_access, :lax_parsing]
+  config.missing_features = [:self_environment_shadowing, :drop_class_output, :shopify_filters, :shopify_includes, :shopify_blank, :shopify_error_handling, :shopify_error_format, :shopify_string_access, :lax_parsing, :strict2_blank_body_errors]
 end
 
 LiquidSpec.compile do |ctx, source, parse_options|

lib/liquid/spec/cli/features.rb

@@ -97,6 +97,11 @@ module Features
             recommendation: :unnecessary,
             note: "Binary data can't be transmitted in JSON without base64 encoding.",
           },
+          strict2_blank_body_errors: {
+            description: "strict2 surfaces inline errors even when the block body is blank",
+            recommendation: :unnecessary,
+            note: "Aspirational 'NEW STRICT2 CONTRACT' not yet implemented by liquid-ruby 5.13 (it still suppresses blank-body errors). Opt out until your implementation deliberately adopts this contract.",
+          },
         }.freeze
 
         RECOMMENDATION_LABELS = {

lib/liquid/spec/cli/init.rb

@@ -324,6 +324,7 @@ module Init
               :shopify_error_handling,
               :shopify_error_format,
               :shopify_string_access,
+              :strict2_blank_body_errors,
             ]
           end
 
@@ -393,7 +394,7 @@ def self.agents_md_content(filename, json_rpc: false)
             4. Implement the smallest change that makes the spec pass for the RIGHT reason.
             5. Re-run. Every previously-passing spec must still pass — a fix that breaks
                earlier specs is wrong, not a tradeoff.
-            6. Judge progress by **`Max complexity reached`**, not the raw pass count. A
+            6. Judge progress by **`Complexity level cleared`**, not the raw pass count. A
                partial implementation accidentally passes many later specs whose expected
                output happens to be empty; complexity-reached is the honest meter.
 

lib/liquid/spec/cli/runner.rb

@@ -302,18 +302,19 @@ def run_specs_frozen(config, options, run_id)
             has_prioritized = options[:add_specs] && !options[:add_specs].empty?
             prioritized_specs = has_prioritized ? load_additional_specs(options[:add_specs]) : []
             total_skipped = 0
+            skipped_features = Set.new
             prioritized_specs = filter_specs(prioritized_specs, config.filter) if config.filter && prioritized_specs.any?
             if prioritized_specs.any?
               total_skipped += prioritized_specs.size
-              prioritized_specs = filter_by_missing(prioritized_specs, missing_features)
+              prioritized_specs = filter_by_missing(prioritized_specs, missing_features, skipped_features: skipped_features)
               total_skipped -= prioritized_specs.size
             end
 
             # Auto-discover local specs from ./specs/*.yml
             local_specs = discover_local_specs
             local_specs = filter_specs(local_specs, config.filter) if config.filter && local_specs.any?
             total_skipped += local_specs.size
-            local_specs = filter_by_missing(local_specs, missing_features)
+            local_specs = filter_by_missing(local_specs, missing_features, skipped_features: skipped_features)
             total_skipped -= local_specs.size
             if local_specs.any? && config.verbose && !json_mode
               puts "Auto-including: #{local_specs.size} specs from ./specs/*.yml"
@@ -393,7 +394,7 @@ def run_specs_frozen(config, options, run_id)
 
               suite_specs = filter_specs(suite_specs, config.filter) if config.filter
               total_skipped += suite_specs.size
-              suite_specs = filter_by_missing(suite_specs, missing_features)
+              suite_specs = filter_by_missing(suite_specs, missing_features, skipped_features: skipped_features)
               total_skipped -= suite_specs.size
               suite_specs = sort_by_complexity(suite_specs)
 
@@ -525,7 +526,7 @@ def run_specs_frozen(config, options, run_id)
                 passed_specs: all_passed,
                 list_passed: options[:list_passed],
                 max_failures: max_failures,
-                missing_features: missing_features
+                skipped_features: skipped_features
               )
             end
 
@@ -1422,7 +1423,7 @@ def sort_result_entries(entries)
             end
           end
 
-          def print_run_summary(total_passed:, total_failed:, total_errors:, max_complexity_reached:, max_possible:, total_skipped:, failures:, known_fixed:, passed_specs:, list_passed:, max_failures:, missing_features:)
+          def print_run_summary(total_passed:, total_failed:, total_errors:, max_complexity_reached:, max_possible:, total_skipped:, failures:, known_fixed:, passed_specs:, list_passed:, max_failures:, skipped_features:)
             failures_count = total_failed + total_errors
             if failures.any?
               puts "Next best specs to work on:"
@@ -1431,41 +1432,40 @@ def print_run_summary(total_passed:, total_failed:, total_errors:, max_complexit
             end
             print_known_fixed(known_fixed) if known_fixed.any?
             print_passed_specs(passed_specs) if list_passed
-            parts = ["Complexity level cleared: #{max_complexity_reached}", "#{total_passed} passes", "#{failures_count} failures"]
+            parts = ["Complexity level cleared: #{max_complexity_reached} of #{max_possible}", "#{total_passed} passes", "#{failures_count} failures"]
             parts << "#{total_skipped} skipped" if total_skipped > 0
             puts parts.join(", ") + "."
 
-            # Congrats addendum: 100% of the run passes (no failures, bar at max).
-            print_congrats(total_skipped, missing_features) if failures_count == 0 && max_complexity_reached == max_possible
+            # Congrats addendum: 100% of the run passes (no failures, level = max).
+            print_congrats(skipped_features) if failures_count == 0 && max_complexity_reached == max_possible
           end
 
           # Printed when an adapter clears the full complexity bar (0 failures, bar = max).
           # Suggests 3 paths forward: implement more features, benchmark, or give back.
-          def print_congrats(total_skipped, missing_features)
+          def print_congrats(skipped_features)
             puts ""
             puts "Congrats! You cleared the complexity bar — every spec you ran passes."
             puts ""
             puts "3 paths forward:"
             puts ""
             docs = Features::FEATURE_DOCS
-            optional = missing_features.select { |f| docs.dig(f.to_sym, :recommendation) == :optional }
-            skipped_other = missing_features.size - optional.size
+            optional = skipped_features.select { |f| docs.dig(f.to_sym, :recommendation) == :optional }
+            other = skipped_features.size - optional.size
             if optional.any?
-              puts "  1. Implement an optional feature you currently opt out of. Each unblocks skipped specs:"
+              puts "  1. Implement an optional feature you skipped specs for this run. Each unblocks more:"
               optional.each do |f|
-                d = docs[f.to_sym]
-                puts "       - #{f}: #{d[:description]}"
+                puts "       - #{f}: #{docs[f.to_sym][:description]}"
               end
               puts "     Pros: more coverage, closer to production/theme-ready."
               puts "     Cons: each needs design + testing; Shopify features need platform context."
-              if skipped_other > 0
-                puts "     (#{skipped_other} other opted-out feature#{skipped_other == 1 ? "" : "s"} are Ruby-interop or core and not worth implementing for a non-Ruby adapter.)"
+              if other > 0
+                puts "     (#{other} other skipped feature#{other == 1 ? "" : "s"} are Ruby-interop or core — not worth implementing for a non-Ruby adapter.)"
               end
-            elsif missing_features.any?
-              puts "  1. Your opted-out features (#{missing_features.join(", ")}) are all Ruby-interop or core —"
-              puts "     not worth implementing for a non-Ruby adapter. Try the shopify_theme_dawn suite"
-              puts "     (-s shopify_theme_dawn) for real-world theme specs instead. Pros: production-shaped"
-              puts "       coverage. Cons: requires Shopify-specific tags/objects/filters."
+            elsif skipped_features.any?
+              puts "  1. The features you skipped specs for (#{skipped_features.map(&:to_s).join(", ")}) are all"
+              puts "     Ruby-interop or core — not worth implementing for a non-Ruby adapter. Try the"
+              puts "     shopify_theme_dawn suite (-s shopify_theme_dawn) for real-world theme specs."
+              puts "     Pros: production-shaped coverage. Cons: requires Shopify tags/objects/filters."
             else
               puts "  1. Push beyond the suite: try the shopify_theme_dawn suite (-s shopify_theme_dawn)"
               puts "     for real-world theme specs. Pros: production-shaped coverage."
@@ -2008,9 +2008,15 @@ def load_additional_specs(globs)
             specs
           end
 
-          def filter_by_missing(specs, missing_features)
+          def filter_by_missing(specs, missing_features, skipped_features: nil)
             missing_set = Set.new(missing_features.map(&:to_sym))
-            specs.reject { |s| s.skipped_by?(missing_set) }
+            specs.reject do |s|
+              skipped = s.skipped_by?(missing_set)
+              if skipped && skipped_features
+                (s.features & missing_set.to_a).each { |f| skipped_features << f }
+              end
+              skipped
+            end
           end
 
           def parse_filter_pattern(pattern)

specs/liquid_ruby/blank_body_error_handling.yml

@@ -200,6 +200,7 @@ specs:
   template: "{% if 5 > \"x\" %}{% endif %}"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): comparison of Integer with String failed"
   complexity: 750
   hint: |
@@ -211,6 +212,7 @@ specs:
   template: "{% if 5 > \"x\" %}   {% endif %}"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): comparison of Integer with String failed"
   complexity: 750
   hint: |
@@ -221,6 +223,7 @@ specs:
   template: "{% if 5 > \"x\" %}{% assign a = 1 %}{% endif %}"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): comparison of Integer with String failed"
   complexity: 750
   hint: |
@@ -232,6 +235,7 @@ specs:
   template: "{% if 5 > \"x\" %}{% comment %}c{% endcomment %}{% endif %}"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): comparison of Integer with String failed"
   complexity: 750
   hint: |
@@ -242,6 +246,7 @@ specs:
   template: "{% if 5 > \"x\" %}{% capture c %}text{% endcapture %}{% endif %}"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): comparison of Integer with String failed"
   complexity: 750
   hint: |
@@ -253,6 +258,7 @@ specs:
   template: "{% unless 5 > \"x\" %} {% endunless %}"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): comparison of Integer with String failed"
   complexity: 750
   hint: |
@@ -265,6 +271,7 @@ specs:
     xs: "bad"
   error_mode: strict2
   render_errors: true
+  features: [strict2_blank_body_errors]
   expected: "Liquid error (line 1): invalid integer"
   complexity: 750
   hint: |