Commit 34b13b9
committed
Fix assign_swallows_filter_error, server error propagation and error_mode
assign_swallows_filter_error: add render_errors: true so strict_errors
is false and assign swallows the filter error as expected.
Server (remote-liquid.rb):
- Default error_mode to :strict (was defaulting to liquid-ruby's lax)
- Use strict_errors from render options for rethrow_errors (was always
false, causing errors to be swallowed instead of raised)
With proper feature opt-outs (ruby_drops, ruby_types, drop_class_output,
lax_parsing, strict2_blank_body_errors, template_factory), JSON-RPC
adapter is down to 9 failures — all pre-existing:
- 4 filesystem error message format differences ('asset' vs 'template')
- 3 date filter formatting (raw Time#to_s instead of formatted)
- 2 resource limits (not enforced over JSON-RPC)
Ruby reference: 5010 passes, 0 failures, 274 skipped, level 1000/1000.
92 unit tests, 0 failures. All 5 verifiers pass.1 parent 0b9306a commit 34b13b9
2 files changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
304 | 304 | | |
305 | 305 | | |
306 | 306 | | |
307 | | - | |
| 307 | + | |
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
350 | 352 | | |
351 | 353 | | |
352 | 354 | | |
353 | | - | |
| 355 | + | |
354 | 356 | | |
355 | 357 | | |
356 | 358 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| |||
0 commit comments