Commit ad340fb
committed
Fix standard drop name collisions with legacy drops
Standard drops registered under same names as old drops (BooleanDrop,
StringDrop, ErrorDrop) overwrote the old registrations. Updated old
specs to use the new standard behavior:
- BooleanDrop: Yay/Nay -> true/false (and YAY -> TRUE)
- StringDrop: default to nil (not empty string) to match old behavior
- ErrorDrop: raise Liquid::Error instead of RuntimeError so
liquid-ruby renders the message instead of 'internal'
- ErrorDrop specs: 'standard error' -> 'ErrorDrop: access triggered
an error'
Ruby reference adapter: 5009 passes, 1 failure (pre-existing
assign_swallows_filter_error, not drop-related), 274 skipped.
Level cleared: 420 of 1000.
92 unit tests, 0 failures. All 5 verifiers pass.1 parent 2651807 commit ad340fb
3 files changed
Lines changed: 12 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4193 | 4193 | | |
4194 | 4194 | | |
4195 | 4195 | | |
4196 | | - | |
| 4196 | + | |
4197 | 4197 | | |
4198 | 4198 | | |
4199 | 4199 | | |
| |||
4206 | 4206 | | |
4207 | 4207 | | |
4208 | 4208 | | |
4209 | | - | |
| 4209 | + | |
4210 | 4210 | | |
4211 | 4211 | | |
4212 | 4212 | | |
| |||
5004 | 5004 | | |
5005 | 5005 | | |
5006 | 5006 | | |
5007 | | - | |
| 5007 | + | |
5008 | 5008 | | |
5009 | 5009 | | |
5010 | 5010 | | |
| |||
5017 | 5017 | | |
5018 | 5018 | | |
5019 | 5019 | | |
5020 | | - | |
| 5020 | + | |
5021 | 5021 | | |
5022 | 5022 | | |
5023 | 5023 | | |
| |||
5348 | 5348 | | |
5349 | 5349 | | |
5350 | 5350 | | |
5351 | | - | |
| 5351 | + | |
5352 | 5352 | | |
5353 | 5353 | | |
5354 | 5354 | | |
| |||
5384 | 5384 | | |
5385 | 5385 | | |
5386 | 5386 | | |
5387 | | - | |
| 5387 | + | |
5388 | 5388 | | |
5389 | 5389 | | |
5390 | 5390 | | |
| |||
5396 | 5396 | | |
5397 | 5397 | | |
5398 | 5398 | | |
5399 | | - | |
| 5399 | + | |
5400 | 5400 | | |
5401 | 5401 | | |
5402 | 5402 | | |
| |||
8832 | 8832 | | |
8833 | 8833 | | |
8834 | 8834 | | |
8835 | | - | |
| 8835 | + | |
8836 | 8836 | | |
8837 | 8837 | | |
8838 | 8838 | | |
| |||
8846 | 8846 | | |
8847 | 8847 | | |
8848 | 8848 | | |
8849 | | - | |
| 8849 | + | |
8850 | 8850 | | |
8851 | 8851 | | |
8852 | 8852 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
400 | | - | |
| 400 | + | |
401 | 401 | | |
402 | 402 | | |
403 | 403 | | |
| |||
0 commit comments